Hoo man has uploaded a new change for review.
https://gerrit.wikimedia.org/r/277351
Change subject: Remove ActionTestCase::shouldTestRedirects
......................................................................
Remove ActionTestCase::shouldTestRedirects
No longer needed, see also 08ccacacc55540408a7fcecf7fdb282459d0405b
Change-Id: I193d469254a0e8e22542b81a61a76985f45959c5
---
M repo/tests/phpunit/includes/Actions/ActionTestCase.php
1 file changed, 5 insertions(+), 14 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/51/277351/1
diff --git a/repo/tests/phpunit/includes/Actions/ActionTestCase.php
b/repo/tests/phpunit/includes/Actions/ActionTestCase.php
index 6d4e945..39d27ee 100644
--- a/repo/tests/phpunit/includes/Actions/ActionTestCase.php
+++ b/repo/tests/phpunit/includes/Actions/ActionTestCase.php
@@ -5,10 +5,8 @@
use Action;
use ApiQueryInfo;
use Article;
-use ContentHandler;
use Exception;
use FauxRequest;
-use Language;
use MWException;
use OutputPage;
use RequestContext;
@@ -78,11 +76,6 @@
$wgUser->removeGroup( "dummy" );
}
- protected function shouldTestRedirects() {
- $handler = ContentHandler::getForModelID(
CONTENT_MODEL_WIKIBASE_ITEM );
- return $handler->supportsRedirects();
- }
-
/**
* @var EntityDocument[]|EntityRedirect[] List of EntityDocument or
EntityRedirect objects,
* with logical handles as keys.
@@ -125,14 +118,12 @@
$item->setLabel( 'en', 'Oslo' );
$items['Oslo'][] = $item;
- if ( $this->shouldTestRedirects() ) {
- $item = new Item();
- $item->setLabel( 'de', 'Berlin' );
- $items['Berlin2'][] = $item;
+ $item = new Item();
+ $item->setLabel( 'de', 'Berlin' );
+ $items['Berlin2'][] = $item;
- // HACK: this revision is a redirect
- $items['Berlin2'][] = 'Berlin';
- }
+ // HACK: this revision is a redirect
+ $items['Berlin2'][] = 'Berlin';
return $items;
}
--
To view, visit https://gerrit.wikimedia.org/r/277351
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I193d469254a0e8e22542b81a61a76985f45959c5
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Hoo man <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
