AbdealiJK has uploaded a new change for review. https://gerrit.wikimedia.org/r/277465
Change subject: proofreadpage_tests: Require bs4 for setUpClass ...................................................................... proofreadpage_tests: Require bs4 for setUpClass The class IndexPageTestCase earlier checked for bs4 as a class decorator. But that check doesn't seem to work and is a known bug in node. We add the required_module() decorator to the setUpClass also so that it is not run. The related issue on nose's github repository can be found at https://github.com/nose-devs/nose/issues/946 Bug: T129965 Change-Id: Iec2f706aa832f7bd20e56fbc3427e8f315499591 --- M tests/proofreadpage_tests.py 1 file changed, 5 insertions(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/pywikibot/core refs/changes/65/277465/1 diff --git a/tests/proofreadpage_tests.py b/tests/proofreadpage_tests.py index 39b464b..5e7bc28 100644 --- a/tests/proofreadpage_tests.py +++ b/tests/proofreadpage_tests.py @@ -285,7 +285,11 @@ """Run tests related to IndexPage ProofreadPage extension.""" - pass + @classmethod + @require_modules('bs4') + def setUpClass(cls): + """Set up test case.""" + super(TestIndexPageMappings, cls).setUpClass() class TestIndexPageInvalidSite(IndexPageTestCase): -- To view, visit https://gerrit.wikimedia.org/r/277465 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Iec2f706aa832f7bd20e56fbc3427e8f315499591 Gerrit-PatchSet: 1 Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Owner: AbdealiJK <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
