Jforrester has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/277760

Change subject: [Re-apply] testsuitegenerator: Test every triple of config 
options for ButtonWidget
......................................................................

[Re-apply] testsuitegenerator: Test every triple of config options for 
ButtonWidget

This re-applies commit 4380924b8b66cd2654e1b53a297bfbf4a85698c9 and so reverts 
commit 73a83a12d6299e9af28f3ecdd7599c0f86fa4656.

Let's not do this until we work out how to avoid breaking CI. :-)

Change-Id: I105ed6af240e17b3ec25d0de558a09be007ecf84
---
M bin/testsuitegenerator.rb
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/oojs/ui refs/changes/60/277760/1

diff --git a/bin/testsuitegenerator.rb b/bin/testsuitegenerator.rb
index 1713060..05c8cee 100644
--- a/bin/testsuitegenerator.rb
+++ b/bin/testsuitegenerator.rb
@@ -113,7 +113,7 @@
                required_config = klass[:methods][0][:params] || []
 
                # generate every possible configuration of configuration option 
sets
-               maxlength = [config.length, 2].min
+               maxlength = [config.length, klass[:name] == 'ButtonWidget' ? 3 
: 2].min
                config_combinations = (0..maxlength).map{|l| 
config.combination(l).to_a }.inject(:+)
                # for each set, generate all possible values to use based on 
option's type
                config_combinations = config_combinations.map{|config_comb|

-- 
To view, visit https://gerrit.wikimedia.org/r/277760
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I105ed6af240e17b3ec25d0de558a09be007ecf84
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Jforrester <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to