jenkins-bot has submitted this change and it was merged. Change subject: Drop "new Statement( $claim )" code from StatementGroupListView ......................................................................
Drop "new Statement( $claim )" code from StatementGroupListView This looks like it was written to support Statement objects and Claim objects. A Claim was wrapped in a Statement. Change-Id: Ib03d8d3dbaa73426b8ef36b08cf36b1ab7b8be1b --- M view/src/StatementGroupListView.php 1 file changed, 1 insertion(+), 3 deletions(-) Approvals: Adrian Heine: Looks good to me, approved jenkins-bot: Verified diff --git a/view/src/StatementGroupListView.php b/view/src/StatementGroupListView.php index 9ec963e..fbb87a4 100644 --- a/view/src/StatementGroupListView.php +++ b/view/src/StatementGroupListView.php @@ -122,9 +122,7 @@ foreach ( $statements as $statement ) { $statementViewsHtml .= $this->claimHtmlGenerator->getHtmlForClaim( $statement, - $this->editSectionGenerator->getStatementEditSection( - $statement instanceof Statement ? $statement : new Statement( $statement ) - ) + $this->editSectionGenerator->getStatementEditSection( $statement ) ); } -- To view, visit https://gerrit.wikimedia.org/r/277995 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib03d8d3dbaa73426b8ef36b08cf36b1ab7b8be1b Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Thiemo Mättig (WMDE) <thiemo.maet...@wikimedia.de> Gerrit-Reviewer: Adrian Heine <adrian.l...@wikimedia.de> Gerrit-Reviewer: Bene <benestar.wikime...@gmail.com> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits