Jforrester has uploaded a new change for review.
https://gerrit.wikimedia.org/r/277763
Change subject: rubocop: Re-run todos, upgrade to newer rule names
......................................................................
rubocop: Re-run todos, upgrade to newer rule names
Change-Id: Ied27c2d2fbab093e8563f50608306f8ad41b6adc
---
M .rubocop.yml
A .rubocop_todo.yml
2 files changed, 73 insertions(+), 4 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/oojs/ui refs/changes/63/277763/1
diff --git a/.rubocop.yml b/.rubocop.yml
index a1b33cc..c5b0c59 100644
--- a/.rubocop.yml
+++ b/.rubocop.yml
@@ -1,3 +1,5 @@
+inherit_from: .rubocop_todo.yml
+
AllCops:
Include:
- 'bin/*.rb'
@@ -24,8 +26,6 @@
Enabled: false
# Opinions differ.
-Style/Blocks:
- Enabled: false
Style/NegatedIf:
Enabled: false
Style/Tab:
@@ -61,10 +61,12 @@
Enabled: false
Style/SpaceInsideBlockBraces:
Enabled: false
-Style/TrailingComma:
+Style/TrailingCommaInLiteral:
+ Enabled: false
+Style/TrailingCommaInArguments:
Enabled: false
Style/WordArray:
- MinSize: 2
+ MinSize: 3
# RuboCop bug causes false positives.
Style/CommentIndentation:
diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
new file mode 100644
index 0000000..d0e4c22
--- /dev/null
+++ b/.rubocop_todo.yml
@@ -0,0 +1,67 @@
+# This configuration was generated by
+# `rubocop --auto-gen-config`
+# on 2016-03-16 13:16:59 +0000 using RuboCop version 0.36.0.
+# The point is for the user to remove these configuration records
+# one by one as the offenses are removed from the code base.
+# Note that changes in the inspected code, or installation of new
+# versions of RuboCop, may require this file to be generated again.
+
+# Offense count: 10
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles, ProceduralMethods,
FunctionalMethods, IgnoredMethods.
+# SupportedStyles: line_count_based, semantic, braces_for_chaining
+# ProceduralMethods: benchmark, bm, bmbm, create, each_with_object, measure,
new, realtime, tap, with_object
+# FunctionalMethods: let, let!, subject, watch
+# IgnoredMethods: lambda, proc, it
+Style/BlockDelimiters:
+ Exclude:
+ - 'bin/doccomparer.rb'
+ - 'bin/docparser.rb'
+ - 'bin/testsuitegenerator.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: SingleLineConditionsOnly.
+Style/ConditionalAssignment:
+ Exclude:
+ - 'bin/docparser.rb'
+
+# Offense count: 1
+Style/IfInsideElse:
+ Exclude:
+ - 'bin/doccomparer.rb'
+
+# Offense count: 2
+# Cop supports --auto-correct.
+# Configuration parameters: IndentationWidth.
+Style/IndentAssignment:
+ Exclude:
+ - 'bin/docparser.rb'
+ - 'bin/testsuitegenerator.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+Style/MethodCallParentheses:
+ Exclude:
+ - 'bin/testsuitegenerator.rb'
+
+# Offense count: 17
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles, IndentationWidth.
+# SupportedStyles: aligned, indented
+Style/MultilineMethodCallIndentation:
+ Enabled: false
+
+# Offense count: 1
+# Cop supports --auto-correct.
+Style/ParallelAssignment:
+ Exclude:
+ - 'bin/doccomparer.rb'
+
+# Offense count: 7
+# Cop supports --auto-correct.
+# Configuration parameters: SupportedStyles, WordRegex.
+# SupportedStyles: percent, brackets
+Style/WordArray:
+ EnforcedStyle: percent
+ MinSize: 3
--
To view, visit https://gerrit.wikimedia.org/r/277763
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ied27c2d2fbab093e8563f50608306f8ad41b6adc
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Jforrester <jforres...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
