[MediaWiki-commits] [Gerrit] Declare functions with access modifiers - change (mediawiki...Interwiki)

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged.

Change subject: Declare functions with access modifiers
......................................................................


Declare functions with access modifiers

Change-Id: Ib7180f15a1c7c4a40cea9c2eedc318ed26f1edab
---
M Interwiki_body.php
1 file changed, 5 insertions(+), 5 deletions(-)

Approvals:
  Legoktm: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/Interwiki_body.php b/Interwiki_body.php
index 438c991..e66745f 100644
--- a/Interwiki_body.php
+++ b/Interwiki_body.php
@@ -110,7 +110,7 @@
        /**
         * @param $action string
         */
-       function showForm( $action ) {
+       protected function showForm( $action ) {
                $request = $this->getRequest();
 
                $prefix = $request->getVal( 'prefix' );
@@ -219,7 +219,7 @@
                $this->getOutput()->addHTML( $form );
        }
 
-       function doSubmit() {
+       protected function doSubmit() {
                global $wgContLang;
 
                $request = $this->getRequest();
@@ -302,7 +302,7 @@
                }
        }
 
-       function showList() {
+       protected function showList() {
                global $wgInterwikiCentralDB, $wgInterwikiViewOnly;
                $canModify = $this->canModify();
 
@@ -418,7 +418,7 @@
                }
        }
 
-       function makeTable( $canModify, $iwPrefixes ) {
+       protected function makeTable( $canModify, $iwPrefixes ) {
                // Output the existing Interwiki prefixes table header
                $out = '';
                $out .= Html::openElement(
@@ -490,7 +490,7 @@
                $this->getOutput()->addHTML( $out );
        }
 
-       function error() {
+       protected function error() {
                $args = func_get_args();
                $this->getOutput()->wrapWikiMsg( "<p class='error'>$1</p>", 
$args );
        }

-- 
To view, visit https://gerrit.wikimedia.org/r/275469
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib7180f15a1c7c4a40cea9c2eedc318ed26f1edab
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Interwiki
Gerrit-Branch: master
Gerrit-Owner: Siebrand <siebr...@kitano.nl>
Gerrit-Reviewer: Legoktm <legoktm.wikipe...@gmail.com>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits