Aaron Schulz has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/278312

Change subject: Make authenticate() respect read-only mode
......................................................................

Make authenticate() respect read-only mode

Bug: T129968
Change-Id: Icb4b34e7d5a8122aad0f9c6875230f1e9683e29c
---
M includes/CentralAuthUser.php
1 file changed, 4 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CentralAuth 
refs/changes/12/278312/1

diff --git a/includes/CentralAuthUser.php b/includes/CentralAuthUser.php
index e1ceb22..63b4a61 100644
--- a/includes/CentralAuthUser.php
+++ b/includes/CentralAuthUser.php
@@ -1839,7 +1839,10 @@
 
                        $passwordFactory = new PasswordFactory();
                        $passwordFactory->init( 
RequestContext::getMain()->getConfig() );
-                       if ( $passwordFactory->needsUpdate( $status->getValue() 
) ) {
+                       if (
+                               $passwordFactory->needsUpdate( 
$status->getValue() )
+                               && 
!CentralAuthUtils::getCentralDB()->isReadOnly()
+                       ) {
                                $this->setPassword( $password );
                                $this->saveSettings();
                        }

-- 
To view, visit https://gerrit.wikimedia.org/r/278312
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Icb4b34e7d5a8122aad0f9c6875230f1e9683e29c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CentralAuth
Gerrit-Branch: master
Gerrit-Owner: Aaron Schulz <asch...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to