TheDJ has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/278574

Change subject: Remove double normalization of audio player width
......................................................................

Remove double normalization of audio player width

This is duplicat with the check done by normaliseParams.

Change-Id: I324c0892a03e2e3c23209f2a5de2f79f00274d94
---
M TimedMediaHandler_body.php
1 file changed, 0 insertions(+), 6 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/TimedMediaHandler 
refs/changes/74/278574/1

diff --git a/TimedMediaHandler_body.php b/TimedMediaHandler_body.php
index e5d0c70..93fe385 100644
--- a/TimedMediaHandler_body.php
+++ b/TimedMediaHandler_body.php
@@ -364,12 +364,6 @@
                $srcWidth = $file->getWidth();
                $srcHeight = $file->getHeight();
 
-               // Audio should not be transformed by size, give it a default 
width and height
-               if ( $this->isAudio( $file ) ) {
-                       $srcWidth = 220;
-                       $srcHeight = 23;
-               }
-
                $params['width'] = isset( $params['width'] ) ? $params['width'] 
: $srcWidth;
 
                // if height overtakes width use height as max:

-- 
To view, visit https://gerrit.wikimedia.org/r/278574
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I324c0892a03e2e3c23209f2a5de2f79f00274d94
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/TimedMediaHandler
Gerrit-Branch: master
Gerrit-Owner: TheDJ <hartman.w...@gmail.com>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to