Yaron Koren has uploaded a new change for review. https://gerrit.wikimedia.org/r/278727
Change subject: Removed unused method SFTemplateField::createFromList() ...................................................................... Removed unused method SFTemplateField::createFromList() Change-Id: I1bf870c744ad16450b3e94c21996e7c3edcf5d5c --- M includes/SF_TemplateField.php 1 file changed, 0 insertions(+), 26 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SemanticForms refs/changes/27/278727/1 diff --git a/includes/SF_TemplateField.php b/includes/SF_TemplateField.php index f379ffa..63f7b89 100644 --- a/includes/SF_TemplateField.php +++ b/includes/SF_TemplateField.php @@ -45,32 +45,6 @@ return $f; } - /** - * Create an SFTemplateField object based on the corresponding field - * in the template definition (which we first have to find) - */ - static function createFromList( $field_name, $all_fields, $strict_parsing ) { - // See if this field matches one of the fields defined for - // the template it's part of - if it is, use all available - // information about that field; if it's not, either create - // an object for it or not, depending on whether the - // template has a 'strict' setting in the form definition. - $the_field = null; - foreach ( $all_fields as $cur_field ) { - if ( $field_name == $cur_field->mFieldName ) { - $the_field = $cur_field; - break; - } - } - if ( $the_field == null ) { - if ( $strict_parsing ) { - return null; - } - $the_field = new SFTemplateField(); - } - return $the_field; - } - function setTypeAndPossibleValues() { if ( !defined( 'SMW_NS_PROPERTY' ) ) { return; -- To view, visit https://gerrit.wikimedia.org/r/278727 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I1bf870c744ad16450b3e94c21996e7c3edcf5d5c Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/SemanticForms Gerrit-Branch: master Gerrit-Owner: Yaron Koren <yaro...@gmail.com> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits