jenkins-bot has submitted this change and it was merged. Change subject: Fix exception on jquery ui slider update ......................................................................
Fix exception on jquery ui slider update The jquery ui slider implementation uses $.data to check if the element is initialized, but this data is cleaned up when the slider is removed from the dom. The playhead is updated after the slider is removed from the dom however. Bug: T126234 Change-Id: Ib3439b405e196dce73e82253832115d153e3eb78 --- M MwEmbedModules/EmbedPlayer/resources/mw.EmbedPlayer.js 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Bartosz Dziewoński: Looks good to me, approved jenkins-bot: Verified diff --git a/MwEmbedModules/EmbedPlayer/resources/mw.EmbedPlayer.js b/MwEmbedModules/EmbedPlayer/resources/mw.EmbedPlayer.js index 131302a..441f4f2 100644 --- a/MwEmbedModules/EmbedPlayer/resources/mw.EmbedPlayer.js +++ b/MwEmbedModules/EmbedPlayer/resources/mw.EmbedPlayer.js @@ -2644,7 +2644,7 @@ //mw.log( 'EmbedPlayer: updatePlayHead: '+ perc); if( this.getInterface() ){ var $playHead = this.getInterface().find( '.play_head' ); - if ( !this.useNativePlayerControls() && $playHead.length != 0 ) { + if ( !this.useNativePlayerControls() && $playHead.length != 0, $.contains( document, $playHead[0] ) ) { var val = parseInt( perc * 1000 ); $playHead.slider( 'value', val ); } -- To view, visit https://gerrit.wikimedia.org/r/278680 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib3439b405e196dce73e82253832115d153e3eb78 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/TimedMediaHandler Gerrit-Branch: master Gerrit-Owner: TheDJ <hartman.w...@gmail.com> Gerrit-Reviewer: Bartosz Dziewoński <matma....@gmail.com> Gerrit-Reviewer: Brion VIBBER <br...@wikimedia.org> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits