jenkins-bot has submitted this change and it was merged.
Change subject: git-update: Stop services before updating their dependencies
......................................................................
git-update: Stop services before updating their dependencies
Bug: T129166
Change-Id: I72841d3e27d1fc37e0b83642904de53aed6d81df
---
M puppet/modules/mediawiki/templates/run-git-update.erb
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
BryanDavis: Looks good to me, approved
Krinkle: Looks good to me, but someone else must approve
jenkins-bot: Verified
diff --git a/puppet/modules/mediawiki/templates/run-git-update.erb
b/puppet/modules/mediawiki/templates/run-git-update.erb
index de7a048..4607185 100644
--- a/puppet/modules/mediawiki/templates/run-git-update.erb
+++ b/puppet/modules/mediawiki/templates/run-git-update.erb
@@ -27,6 +27,7 @@
cd $SERVICE_DIR
if [[ -n $UPDATE_CMD ]]; then
echo "[*] Updating dependencies for ${SERVICE_NAME} ..."
+ [[ -n ${DO_RESTART} ]] && sudo service ${RESTART_NAME} stop
if ! /bin/sh -c "$UPDATE_CMD"; then
ERR="Could not update dependencies of ${SERVICE_NAME} !"
echo -e "\e[1;31m ***** ${ERR}\e[0m"
@@ -36,7 +37,7 @@
fi
if [[ -n $DO_RESTART && -z $ERR ]]; then
echo "[*] Restarting service ${RESTART_NAME} ..."
- sudo service ${RESTART_NAME} restart
+ sudo service ${RESTART_NAME} start
fi
echo
}
--
To view, visit https://gerrit.wikimedia.org/r/279252
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I72841d3e27d1fc37e0b83642904de53aed6d81df
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/vagrant
Gerrit-Branch: master
Gerrit-Owner: Mobrovac <mobro...@wikimedia.org>
Gerrit-Reviewer: BryanDavis <bda...@wikimedia.org>
Gerrit-Reviewer: Dduvall <dduv...@wikimedia.org>
Gerrit-Reviewer: Krinkle <krinklem...@gmail.com>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
