Nikerabbit has uploaded a new change for review.
https://gerrit.wikimedia.org/r/279321
Change subject: Remove unneeded return trues from most hooks
......................................................................
Remove unneeded return trues from most hooks
Change-Id: I6f3d1e1da3f782823975ab2833b3b92bfcb9026c
---
M TranslateHooks.php
1 file changed, 1 insertion(+), 41 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Translate
refs/changes/21/279321/1
diff --git a/TranslateHooks.php b/TranslateHooks.php
index 10a8af5..fa36cd9 100644
--- a/TranslateHooks.php
+++ b/TranslateHooks.php
@@ -26,14 +26,11 @@
'localBasePath' => __DIR__,
'remoteExtPath' => 'Translate',
);
-
- return true;
}
/**
* Hook: CanonicalNamespaces
* @param $list array
- * @return bool
*/
public static function setupNamespaces( &$list ) {
global $wgPageTranslationNamespace, $wgNamespaceRobotPolicies;
@@ -44,8 +41,6 @@
$list[NS_TRANSLATIONS] = 'Translations';
$list[NS_TRANSLATIONS_TALK] = 'Translations_talk';
$wgNamespaceRobotPolicies[NS_TRANSLATIONS] = 'noindex';
-
- return true;
}
/**
@@ -232,20 +227,15 @@
* Registers \<languages> tag with the parser.
*
* @param $parser Parser
- *
- * @return bool
*/
public static function setupParserHooks( $parser ) {
// For nice language list in-page
$parser->setHook( 'languages', array( 'PageTranslationHooks',
'languages' ) );
-
- return true;
}
/**
* Hook: UnitTestsList
* @param $files array
- * @return bool
*/
public static function setupUnitTests( array &$files ) {
$dir = __DIR__ . '/tests/phpunit';
@@ -258,14 +248,11 @@
$files[] = $fileInfo->getPathname();
}
}
-
- return true;
}
/**
* Hook: LoadExtensionSchemaUpdates
* @param $updater DatabaseUpdater
- * @return bool
*/
public static function schemaUpdates( DatabaseUpdater $updater ) {
$dir = __DIR__ . '/sql';
@@ -357,8 +344,6 @@
"$dir/translate_stash.sql",
true
) );
-
- return true;
}
/**
@@ -369,8 +354,6 @@
$tables[] = 'translate_groupstats';
$tables[] = 'translate_messageindex';
$tables[] = 'translate_stash';
-
- return true;
}
/**
@@ -378,15 +361,12 @@
* Hook: PageContentLanguage
* @param $title Title
* @param $pageLang
- * @return bool
*/
public static function onPageContentLanguage( Title $title, &$pageLang
) {
$handle = new MessageHandle( $title );
if ( $handle->isMessageNamespace() ) {
$pageLang = $handle->getEffectiveLanguage();
}
-
- return true;
}
/**
@@ -407,8 +387,6 @@
$names[$wgTranslateDocumentationLanguageCode] =
wfMessage( 'translate-documentation-language'
)->inLanguage( $code )->plain();
}
-
- return true;
}
/**
@@ -437,8 +415,6 @@
$insert,
array_slice( $profiles, $index )
);
-
- return true;
}
/**
@@ -502,7 +478,7 @@
/*string*/$profile, SearchEngine $engine
) {
if ( $profile !== 'translation' ) {
- return true;
+ return;
}
$context = $search->getContext();
@@ -511,8 +487,6 @@
$engine->setFeatureData( 'title-suffix-filter',
"/$selected" );
$search->setExtraParam( 'languagefilter', $selected );
}
-
- return true;
}
/// Hook: Translate:MessageGroupStats:isIncluded
@@ -541,8 +515,6 @@
if ( $handle->isMessageNamespace() && !$handle->isDoc() ) {
$updater->mCategories = array();
}
-
- return true;
}
/**
@@ -572,8 +544,6 @@
$vars['wgTranslatePermissionUrl'] =
$wgTranslatePermissionUrl;
$vars['wgTranslateUseSandbox'] = $wgTranslateUseSandbox;
}
-
- return true;
}
/**
@@ -587,8 +557,6 @@
$row = $tree->getSection( $sectionLabel )->getRow(
'main' );
$row->addItem( ALItem::newFromSpecialPage(
'TranslateSandbox' ) );
}
-
- return true;
}
/**
@@ -607,7 +575,6 @@
*
* @param User $oldUser
* @param User $newUser
- * @return bool
*/
public static function onMergeAccountFromTo( User $oldUser, User
$newUser ) {
$dbw = wfGetDB( DB_MASTER );
@@ -625,15 +592,12 @@
);
}
}
-
- return true;
}
/**
* Handler for E:UserMerge's DeleteAccount hook
*
* @param User $oldUser
- * @return bool
*/
public static function onDeleteAccount( User $oldUser ) {
$dbw = wfGetDB( DB_MASTER );
@@ -648,8 +612,6 @@
);
}
}
-
- return true;
}
/**
@@ -717,8 +679,6 @@
public static function setupTranslateParserFunction( &$parser ) {
$parser->setFunctionHook( 'translation',
'TranslateHooks::translateRenderParserFunction' );
-
- return true;
}
public static function translateRenderParserFunction( $parser ) {
--
To view, visit https://gerrit.wikimedia.org/r/279321
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6f3d1e1da3f782823975ab2833b3b92bfcb9026c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Translate
Gerrit-Branch: master
Gerrit-Owner: Nikerabbit <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
