Mattflaschen has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/279653

Change subject: Clarify comment
......................................................................

Clarify comment

Change-Id: If93ad7446e2bc5a45a65c5811e0b93ca45998d7d
---
M includes/SubmissionHandler.php
1 file changed, 5 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Flow 
refs/changes/53/279653/1

diff --git a/includes/SubmissionHandler.php b/includes/SubmissionHandler.php
index c2ff957..2ba98db 100644
--- a/includes/SubmissionHandler.php
+++ b/includes/SubmissionHandler.php
@@ -101,8 +101,11 @@
                                }
                                // I guess this is the "user block" meaning of 
'block'.  If
                                // so, this is misleading, since it could be 
protection,
-                               // etc.  In theory, something could be using it 
since it's
-                               // exposed to the API, but very unlikely...
+                               // etc.  The specific error message (protect, 
block, etc.)
+                               // will still be output, though.
+                               //
+                               // In theory, something could be relying on the 
string 'block',
+                               // since it's exposed to the API, but probably 
not.
                                reset( $interestedBlocks )->addError( 'block', 
$msg );
                        }
                        return array();

-- 
To view, visit https://gerrit.wikimedia.org/r/279653
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If93ad7446e2bc5a45a65c5811e0b93ca45998d7d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Flow
Gerrit-Branch: master
Gerrit-Owner: Mattflaschen <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to