Kghbln has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/280458

Change subject: Providing some tweaks
......................................................................

Providing some tweaks

* Add license label to show on "Special:Version"
* Switch to consistently use __DIR__
* Add position to wgResourceModules array (required for MW 1.26+)

Bug: T100664
Bug: T123943
Change-Id: I2ced2f89efd5b91d5f82b9db2464db8d78191d6a
---
M SideBarMenu.php
1 file changed, 5 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SideBarMenu 
refs/changes/58/280458/1

diff --git a/SideBarMenu.php b/SideBarMenu.php
index 3c23bbf..709ec92 100644
--- a/SideBarMenu.php
+++ b/SideBarMenu.php
@@ -41,15 +41,17 @@
                'version' => '0.3.0',
                'author' => 'Kim Eik',
                'url' => 'https://www.mediawiki.org/wiki/Extension:SideBarMenu',
-               'descriptionmsg' => 'sidebarmenu-desc'
+               'descriptionmsg' => 'sidebarmenu-desc',
+               'license-name' => 'GPL-3.0+'
        );
 
        //i18n
 $wgMessagesDirs['SideBarMenu'] = __DIR__ . '/i18n';
-$wgExtensionMessagesFiles['SideBarMenu'] = dirname(__FILE__) . 
'/SideBarMenu.i18n.php';
+$wgExtensionMessagesFiles['SideBarMenu'] = __DIR__ . '/SideBarMenu.i18n.php';
 
        //Resources
        $wgResourceModules['ext.sidebarmenu.core'] = array(
+               'position' => 'top',
                'scripts' => array(
                        'js/ext.sidebarmenu.js'
                ),
@@ -64,7 +66,7 @@
                        'sidebarmenu-js-init-error'
                ),
                'group' => 'ext.sidebarmenu',
-               'localBasePath' => dirname(__FILE__),
+               'localBasePath' => __DIR__,
                'remoteExtPath' => 'SideBarMenu'
        );
 

-- 
To view, visit https://gerrit.wikimedia.org/r/280458
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2ced2f89efd5b91d5f82b9db2464db8d78191d6a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/SideBarMenu
Gerrit-Branch: master
Gerrit-Owner: Kghbln <[email protected]>
Gerrit-Reviewer: Kghbln <[email protected]>
Gerrit-Reviewer: Netbrain <[email protected]>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to