VictorPorton has submitted this change and it was merged.
Change subject: Fix extension.json
......................................................................
Fix extension.json
Also add translatable description.
Update grunt-jscs to 2.8.0
Update grunt-contrib-jshint to 1.0.0
AMENDING: A typo in .json file
Bug: T128034
Change-Id: I7d73d0762ed3d9a171b0fe1d8c5719349f18849e
---
M BaseHooks.php
M Gruntfile.js
M extension.json
A i18n/en.json
A i18n/qqq.json
M package.json
6 files changed, 29 insertions(+), 10 deletions(-)
Approvals:
VictorPorton: Verified; Looks good to me, approved
diff --git a/BaseHooks.php b/BaseHooks.php
index 5c3e9c5..7eacab7 100644
--- a/BaseHooks.php
+++ b/BaseHooks.php
@@ -7,13 +7,12 @@
'path' => __FILE__,
'name' => 'BaseHooks',
'version' => '0.0.1',
- 'author' => array( 'Victor Porton',
'[https://www.mediawiki.org/wiki/User:VictorPorton]' ),
-// 'descriptionmsg' => 'googleanalytics-desc',
+ 'author' => array( '[https://www.mediawiki.org/wiki/User:VictorPorton
Victor Porton]' ),
+ 'descriptionmsg' => 'basehooks-desc',
'url' => 'https://www.mediawiki.org/wiki/Extension:BaseHooks',
);
-// $wgMessagesDirs['BaseHooks'] = __DIR__ . '/i18n';
-// $wgExtensionMessagesFiles['BaseHooks'] = __DIR__ . '/BaseHooks.i18n.php';
+$wgMessagesDirs['BaseHooks'] = __DIR__ . '/i18n';
$wgAutoloadClasses['BaseHooksHooks'] = __DIR__ . '/BaseHooks.hooks.php';
$wgHooks['SkinAfterBottomScripts'][] =
'BaseHooksHooks::onSkinAfterBottomScripts';
diff --git a/Gruntfile.js b/Gruntfile.js
index 69e6d05..8c1aff2 100644
--- a/Gruntfile.js
+++ b/Gruntfile.js
@@ -11,8 +11,7 @@
jshintrc: true
},
all: [
- '*.js',
- 'modules/**/*.js'
+ '**/*.js'
]
},
jscs: {
diff --git a/extension.json b/extension.json
index c7c9111..0bc71ce 100644
--- a/extension.json
+++ b/extension.json
@@ -5,14 +5,23 @@
"Victor Porton"
],
"url": "https://www.mediawiki.org/wiki/Extension:BaseHooks";,
- "license-name": "GPL-2.0",
+ "descriptionmsg": "basehooks-desc",
+ "license-name": "GPL-2.0+",
"type": "other",
+ "MessagesDirs": {
+ "BaseHooks": [
+ "i18n"
+ ]
+ },
"AutoloadClasses": {
"BaseHooksHooks": "BaseHooks.hooks.php"
},
"Hooks": {
- "NameOfHook": [
+ "SkinAfterBottomScripts": [
"BaseHooksHooks::onSkinAfterBottomScripts"
+ ],
+ "UnitTestsList": [
+ "BaseHooksHooks::onUnitTestsList"
]
},
"ResourceFileModulePaths": {
diff --git a/i18n/en.json b/i18n/en.json
new file mode 100644
index 0000000..5bb8cf0
--- /dev/null
+++ b/i18n/en.json
@@ -0,0 +1,6 @@
+{
+ "@metadata": {
+ "authors": []
+ },
+ "basehooks-desc": "Add strings or files before end of body tag."
+}
diff --git a/i18n/qqq.json b/i18n/qqq.json
new file mode 100644
index 0000000..ad26ec0
--- /dev/null
+++ b/i18n/qqq.json
@@ -0,0 +1,6 @@
+{
+ "@metadata": {
+ "authors": []
+ },
+ "basehooks-desc":
"{{desc|what=extension|name=BaseHooks|url=https://www.mediawiki.org/wiki/Extension:BaseHooks}}";
+}
diff --git a/package.json b/package.json
index d6d0f28..039659c 100644
--- a/package.json
+++ b/package.json
@@ -6,9 +6,9 @@
"devDependencies": {
"grunt": "0.4.5",
"grunt-cli": "0.1.13",
- "grunt-contrib-jshint": "0.11.3",
+ "grunt-contrib-jshint": "1.0.0",
"grunt-banana-checker": "0.4.0",
- "grunt-jscs": "2.5.0",
+ "grunt-jscs": "2.8.0",
"grunt-jsonlint": "1.0.7"
}
}
--
To view, visit https://gerrit.wikimedia.org/r/280437
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7d73d0762ed3d9a171b0fe1d8c5719349f18849e
Gerrit-PatchSet: 4
Gerrit-Project: mediawiki/extensions/BaseHooks
Gerrit-Branch: master
Gerrit-Owner: Paladox <[email protected]>
Gerrit-Reviewer: Hashar <[email protected]>
Gerrit-Reviewer: JanZerebecki <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: Legoktm <[email protected]>
Gerrit-Reviewer: Reedy <[email protected]>
Gerrit-Reviewer: Siebrand <[email protected]>
Gerrit-Reviewer: Umherirrender <[email protected]>
Gerrit-Reviewer: VictorPorton <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
