jenkins-bot has submitted this change and it was merged.
Change subject: Hygiene: remove MobileWebUIClickTracking schema
......................................................................
Hygiene: remove MobileWebUIClickTracking schema
The data generated by this schema is not being used.
Bug: T122504
Change-Id: If177ed89867a355e350099e18162e454ec8ed8c3
---
M extension.json
M includes/MobileFrontend.hooks.php
D resources/mobile.loggingSchemas/SchemaMobileWebUIClickTracking.js
M resources/mobile.references/ReferencesDrawer.js
M resources/mobile.toc/TableOfContents.js
M resources/skins.minerva.categories/init.js
M resources/skins.minerva.notifications/init.js
M resources/skins.minerva.scripts/init.js
M resources/skins.minerva.scripts/initLogging.js
9 files changed, 9 insertions(+), 108 deletions(-)
Approvals:
Jdlrobson: Looks good to me, approved
jenkins-bot: Verified
diff --git a/extension.json b/extension.json
index 493aefc..0537fdb 100644
--- a/extension.json
+++ b/extension.json
@@ -505,7 +505,6 @@
],
"dependencies": [
"mobile.startup",
- "mobile.loggingSchemas",
"mobile.toggle",
"mobile.toc.images"
],
@@ -1082,8 +1081,7 @@
"dependencies": [
"mobile.drawers",
"mobile.editor.api",
- "mobile.references.images",
- "mobile.loggingSchemas"
+ "mobile.references.images"
],
"messages": [
"mobile-frontend-references-citation-error",
@@ -1687,8 +1685,7 @@
"desktop"
],
"dependencies": [
- "mobile.overlays",
- "mobile.loggingSchemas"
+ "mobile.overlays"
],
"scripts": [
"resources/skins.minerva.categories/init.js"
diff --git a/includes/MobileFrontend.hooks.php
b/includes/MobileFrontend.hooks.php
index 686def5..f293013 100644
--- a/includes/MobileFrontend.hooks.php
+++ b/includes/MobileFrontend.hooks.php
@@ -1093,8 +1093,7 @@
'dependencies' => array(
'mobile.overlays',
'skins.minerva.scripts',
- 'mediawiki.ui.anchor',
- 'mobile.loggingSchemas',
+ 'mediawiki.ui.anchor'
),
'scripts' => array(
'resources/skins.minerva.notifications/init.js',
@@ -1157,7 +1156,6 @@
'MobileWebLanguageSwitcher' => 15302503,
'MobileWebMainMenuClickTracking' => 11568715,
'MobileWebSearch' => 12054448,
- 'MobileWebUIClickTracking' => 10742159,
'MobileWebWatching' => 11761466,
'MobileWebWatchlistClickTracking' => 10720361,
);
@@ -1199,7 +1197,6 @@
'resources/mobile.loggingSchemas/SchemaMobileWeb.js',
'resources/mobile.loggingSchemas/SchemaMobileWebClickTracking.js',
'resources/mobile.loggingSchemas/schemaMobileWebLanguageSwitcher.js',
-
'resources/mobile.loggingSchemas/SchemaMobileWebUIClickTracking.js',
'resources/mobile.loggingSchemas/SchemaMobileWebSearch.js',
);
diff --git a/resources/mobile.loggingSchemas/SchemaMobileWebUIClickTracking.js
b/resources/mobile.loggingSchemas/SchemaMobileWebUIClickTracking.js
deleted file mode 100644
index cbf1fd1..0000000
--- a/resources/mobile.loggingSchemas/SchemaMobileWebUIClickTracking.js
+++ /dev/null
@@ -1,24 +0,0 @@
-( function ( M ) {
- var SchemaMobileWebClickTracking = M.require(
- 'mobile.loggingSchemas/SchemaMobileWebClickTracking' );
-
- /**
- * @class SchemaMobileWebUIClickTracking
- * @extends SchemaMobileWebClickTracking
- */
- function SchemaMobileWebUIClickTracking() {
- SchemaMobileWebClickTracking.apply( this, arguments );
- }
-
- OO.mfExtend( SchemaMobileWebUIClickTracking,
SchemaMobileWebClickTracking, {
- /** @inheritdoc **/
- name: 'MobileWebUIClickTracking',
- /** @inheritdoc */
- isSampled: true,
- /** @inheritdoc */
- samplingRate: 0.1
- } );
-
- M.define( 'mobile.loggingSchemas/SchemaMobileWebUIClickTracking',
- SchemaMobileWebUIClickTracking );
-} )( mw.mobileFrontend );
diff --git a/resources/mobile.references/ReferencesDrawer.js
b/resources/mobile.references/ReferencesDrawer.js
index 4297baf..9d8f362 100644
--- a/resources/mobile.references/ReferencesDrawer.js
+++ b/resources/mobile.references/ReferencesDrawer.js
@@ -1,10 +1,7 @@
( function ( M, $ ) {
var Drawer = M.require( 'mobile.drawers/Drawer' ),
icons = M.require( 'mobile.startup/icons' ),
- Icon = M.require( 'mobile.startup/Icon' ),
- SchemaMobileWebUIClickTracking = M.require(
- 'mobile.loggingSchemas/SchemaMobileWebUIClickTracking'
),
- uiSchema = new SchemaMobileWebUIClickTracking();
+ Icon = M.require( 'mobile.startup/Icon' );
/**
* Drawer for references
@@ -41,9 +38,6 @@
},
/** @inheritdoc */
show: function () {
- uiSchema.log( {
- name: 'reference'
- } );
return Drawer.prototype.show.apply( this, arguments );
},
className: 'drawer position-fixed text references',
diff --git a/resources/mobile.toc/TableOfContents.js
b/resources/mobile.toc/TableOfContents.js
index 2cdd17e..ed2eeb1 100644
--- a/resources/mobile.toc/TableOfContents.js
+++ b/resources/mobile.toc/TableOfContents.js
@@ -1,8 +1,5 @@
( function ( M ) {
- var SchemaMobileWebUIClickTracking = M.require(
- 'mobile.loggingSchemas/SchemaMobileWebUIClickTracking'
),
- uiSchema = new SchemaMobileWebUIClickTracking(),
- View = M.require( 'mobile.view/View' ),
+ var View = M.require( 'mobile.view/View' ),
Icon = M.require( 'mobile.startup/Icon' );
/**
@@ -34,28 +31,7 @@
},
tagName: 'div',
className: 'toc-mobile',
- template: mw.template.get( 'mobile.toc', 'toc.hogan' ),
- events: {
- // Click tracking for table of contents so we can see
if people interact with it
- 'click h2': 'onTocToggle',
- 'click a': 'onLinkClick'
- },
- /**
- * Log toggling the header
- */
- onTocToggle: function () {
- uiSchema.log( {
- name: 'page-toc-toggle'
- } );
- },
- /**
- * Log clicking a TOC link
- */
- onLinkClick: function () {
- uiSchema.log( {
- name: 'page-toc-link'
- } );
- }
+ template: mw.template.get( 'mobile.toc', 'toc.hogan' )
} );
M.define( 'mobile.toc/TableOfContents', TableOfContents );
diff --git a/resources/skins.minerva.categories/init.js
b/resources/skins.minerva.categories/init.js
index ac0c09b..1d14f4a 100644
--- a/resources/skins.minerva.categories/init.js
+++ b/resources/skins.minerva.categories/init.js
@@ -2,9 +2,6 @@
var loader = M.require( 'mobile.overlays/moduleLoader' ),
overlayManager = M.require( 'mobile.startup/overlayManager' ),
- SchemaMobileWebUIClickTracking = M.require(
- 'mobile.loggingSchemas/SchemaMobileWebUIClickTracking'
),
- uiSchema = new SchemaMobileWebUIClickTracking(),
user = M.require( 'mobile.user/user' );
// categories overlay
@@ -47,13 +44,7 @@
* @ignore
*/
function initButton() {
- $( '.category-button' )
- .removeClass( 'hidden' )
- .on( 'click', function () {
- uiSchema.log( {
- name: 'category-button'
- } );
- } );
+ $( '.category-button' ).removeClass( 'hidden' );
}
$( initButton );
diff --git a/resources/skins.minerva.notifications/init.js
b/resources/skins.minerva.notifications/init.js
index 73facc1..7b65dec 100644
--- a/resources/skins.minerva.notifications/init.js
+++ b/resources/skins.minerva.notifications/init.js
@@ -3,10 +3,7 @@
* with the Toast notifications defined by common/toast.js.
*/
( function ( M, $, mw ) {
- var SchemaMobileWebUIClickTracking = M.require(
- 'mobile.loggingSchemas/SchemaMobileWebUIClickTracking'
),
- uiSchema = new SchemaMobileWebUIClickTracking(),
- mainMenu = M.require( 'skins.minerva.scripts/skin'
).getMainMenu(),
+ var mainMenu = M.require( 'skins.minerva.scripts/skin' ).getMainMenu(),
$btn = $( '#secondary-button.user-button' ).parent(),
router = M.require( 'mobile.startup/router' ),
overlayManager = M.require( 'mobile.startup/overlayManager' ),
@@ -39,9 +36,6 @@
// than linking to Special:Notifications.
$( function () {
$btn.on( 'click', function () {
- uiSchema.log( {
- name: 'notifications'
- } );
router.navigate( '#/notifications' );
// Important that we also prevent propagation to avoid
interference with events that may be
// binded on #mw-mf-page-center that close overlay
diff --git a/resources/skins.minerva.scripts/init.js
b/resources/skins.minerva.scripts/init.js
index b7ade83..23db039 100644
--- a/resources/skins.minerva.scripts/init.js
+++ b/resources/skins.minerva.scripts/init.js
@@ -13,9 +13,6 @@
useNewMediaViewer = context.isBetaGroupMember(),
overlayManager = M.require( 'mobile.startup/overlayManager' ),
page = M.getCurrentPage(),
- SchemaMobileWebUIClickTracking = M.require(
- 'mobile.loggingSchemas/SchemaMobileWebUIClickTracking'
),
- uiSchema = new SchemaMobileWebUIClickTracking(),
schemaMobileWebLanguageSwitcher = M.require(
'mobile.loggingSchemas/schemaMobileWebLanguageSwitcher'
),
thumbs = page.getThumbnails(),
@@ -115,10 +112,6 @@
if ( $languageLink.attr( 'href' ) ) {
router.navigate( '/languages' );
}
-
- uiSchema.log( {
- name: 'languages'
- } );
// when local storage is not available ...
if ( previousTapCount === false ) {
diff --git a/resources/skins.minerva.scripts/initLogging.js
b/resources/skins.minerva.scripts/initLogging.js
index ccb5863..2765f1b 100644
--- a/resources/skins.minerva.scripts/initLogging.js
+++ b/resources/skins.minerva.scripts/initLogging.js
@@ -3,27 +3,10 @@
( function ( M, $ ) {
var SchemaMobileWebClickTracking = M.require(
'mobile.loggingSchemas/SchemaMobileWebClickTracking' ),
- SchemaMobileWebUIClickTracking = M.require(
- 'mobile.loggingSchemas/SchemaMobileWebUIClickTracking'
),
skin = M.require( 'skins.minerva.scripts/skin' ),
- mainMenuSchema = new SchemaMobileWebClickTracking( {},
'MobileWebMainMenuClickTracking' ),
- uiSchema = new SchemaMobileWebUIClickTracking();
+ mainMenuSchema = new SchemaMobileWebClickTracking( {},
'MobileWebMainMenuClickTracking' );
$( function () {
- var $profileLink = $( '#mw-mf-last-modified a' )
- .filter( function () {
- return $( this ).children().length === 0;
- } );
-
- $( '#mw-mf-main-menu-button' ).on( 'click', function () {
- uiSchema.log( {
- name: 'hamburger'
- } );
- } );
-
skin.getMainMenu().enableLogging( mainMenuSchema );
- uiSchema.hijackLink( $( '#mw-mf-last-modified a span'
).parent(), 'lastmodified-history' );
- uiSchema.hijackLink( $profileLink, 'lastmodified-profile' );
- uiSchema.hijackLink( '.nearby-button', 'nearby-button' );
} );
} )( mw.mobileFrontend, jQuery );
--
To view, visit https://gerrit.wikimedia.org/r/272966
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If177ed89867a355e350099e18162e454ec8ed8c3
Gerrit-PatchSet: 8
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Bmansurov <[email protected]>
Gerrit-Reviewer: Bmansurov <[email protected]>
Gerrit-Reviewer: Jdlrobson <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
