Jforrester has uploaded a new change for review.
https://gerrit.wikimedia.org/r/280683
Change subject: [Failing test case] Cursoring over empty alienInline nodes
......................................................................
[Failing test case] Cursoring over empty alienInline nodes
This is not working right now.
Bug: T123608
Change-Id: I039e854b9c14e4662d02737fb47bec298f894ad9
---
M tests/ce/ve.ce.Surface.test.js
M tests/dm/ve.dm.example.js
2 files changed, 31 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/VisualEditor/VisualEditor
refs/changes/83/280683/1
diff --git a/tests/ce/ve.ce.Surface.test.js b/tests/ce/ve.ce.Surface.test.js
index 56bb203..04def35 100644
--- a/tests/ce/ve.ce.Surface.test.js
+++ b/tests/ce/ve.ce.Surface.test.js
@@ -538,6 +538,12 @@
[ { type: 'paragraph' }, 'B', 'a', 'r', { type:
'/paragraph' } ]
)
),
+ evilDoc = ve.dm.example.createExampleDocumentFromData(
+ [ { type: 'paragraph' }, 'F', 'o', 'o' ]
+ .concat( ve.dm.example.evilDoc.data.slice() )
+ .concat( [ 'B', 'a', 'r', { type: '/paragraph'
} ]
+ )
+ ),
cases = [
// Within normal text. NOTE: these tests manually force
the cursor to
// move, because we rely on native browser actions for
that.
@@ -648,6 +654,23 @@
expectedData: function () {},
expectedRangeOrSelection: new ve.Range( 19 ),
msg: 'Cursor down off a block node'
+ },
+ // Alien inline double node cursoring (used downstream)
+ {
+ htmlOrDoc: evilDoc,
+ rangeOrSelection: new ve.Range( 4 ),
+ keys: [ 'RIGHT' ],
+ expectedData: function () {},
+ expectedRangeOrSelection: new ve.Range( 4, 6 ),
+ msg: 'Cursor right onto an alien inline double
node'
+ },
+ {
+ htmlOrDoc: evilDoc,
+ rangeOrSelection: new ve.Range( 5 ),
+ keys: [ 'LEFT' ],
+ expectedData: function () {},
+ expectedRangeOrSelection: new ve.Range( 6, 4 ),
+ msg: 'Cursor left onto an alien inline double
node'
}
];
diff --git a/tests/dm/ve.dm.example.js b/tests/dm/ve.dm.example.js
index dc5ab67..2d16fa6 100644
--- a/tests/dm/ve.dm.example.js
+++ b/tests/dm/ve.dm.example.js
@@ -281,6 +281,14 @@
]
};
+ve.dm.example.evilDoc = {
+ html: '<span typeof="ve:Alien"><a href="#"><span
style="display:none;">[1]</span></a></span>',
+ data: [
+ { type: 'alienInline', originalDomElements: $( '<span
typeof="ve:Alien"><a href="#"><span
style="display:none;">[1]</span></a></span>' ).toArray() },
+ { type: '/alienInline' },
+ ]
+};
+
/**
* Serialized HTML.
*
--
To view, visit https://gerrit.wikimedia.org/r/280683
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I039e854b9c14e4662d02737fb47bec298f894ad9
Gerrit-PatchSet: 1
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Jforrester <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
