Bartosz Dziewoński has uploaded a new change for review.
https://gerrit.wikimedia.org/r/280686
Change subject: mw.UploadWizardDeedOwnWork: Fix animation when showing all
licenses
......................................................................
mw.UploadWizardDeedOwnWork: Fix animation when showing all licenses
Calling .fadeIn() first caused the element to appear at full height
immediately, making .slideDown() a no-op. We want it to expand while
fading in.
Change-Id: I45129d9d8a587d66a1ff5636bf21017bb95d0ffe
---
M resources/mw.UploadWizardDeedOwnWork.js
1 file changed, 6 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/UploadWizard
refs/changes/86/280686/1
diff --git a/resources/mw.UploadWizardDeedOwnWork.js
b/resources/mw.UploadWizardDeedOwnWork.js
index 0d06646..9d929ce 100644
--- a/resources/mw.UploadWizardDeedOwnWork.js
+++ b/resources/mw.UploadWizardDeedOwnWork.js
@@ -203,14 +203,18 @@
.promise().done( function () {
swapNodes( thisDeed.authorInput.$element[ 0 ],
thisDeed.fakeAuthorInput.$element[ 0 ] );
} );
-
deed.licenseInputField.$element.slideUp().fadeOut( { queue: false } );
+
deed.licenseInputField.$element
+
.slideUp()
+
.animate( { opacity: 0 }, { queue: false, easing: 'linear' } );
$( this ).msg(
'mwe-upwiz-license-show-all' );
} else {
$crossfader.morphCrossfade( $customDiv )
.promise().done( function () {
swapNodes( thisDeed.authorInput.$element[ 0 ],
thisDeed.fakeAuthorInput.$element[ 0 ] );
} );
-
deed.licenseInputField.$element.fadeIn().slideDown( { queue: false } );
+
deed.licenseInputField.$element
+
.slideDown()
+ .css( {
opacity: 0 } ).animate( { opacity: 1 }, { queue: false, easing: 'linear' } );
$( this ).msg(
'mwe-upwiz-license-show-recommended' );
}
} ) );
--
To view, visit https://gerrit.wikimedia.org/r/280686
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I45129d9d8a587d66a1ff5636bf21017bb95d0ffe
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/UploadWizard
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
