jenkins-bot has submitted this change and it was merged.

Change subject: Replace deprecated userinfo.* scopes and use the equivalents
......................................................................


Replace deprecated userinfo.* scopes and use the equivalents

The userinfo.email and userinfo.profile scopes are deprecated by Google and
kept for backwards compatibility. However, the replacements email and profile
are fully equivalent, which makes the migration as simple as possible by
replacing the scopes, only.

Bug: T110495
Change-Id: Iafa3e0c7342d2baf7bf4a31eddd88c5525ccb626
---
M includes/GoogleLogin.body.php
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Florianschmidtwelzow: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/includes/GoogleLogin.body.php b/includes/GoogleLogin.body.php
index ab4114e..0b5313d 100644
--- a/includes/GoogleLogin.body.php
+++ b/includes/GoogleLogin.body.php
@@ -444,8 +444,8 @@
                $client->setClientId( $glConfig->get( 'GLAppId' ) );
                $client->setClientSecret( $glConfig->get( 'GLSecret' ) );
                $client->setRedirectUri( 
WebRequest::detectServer().$redirectURI );
-               $client->addScope( 
"https://www.googleapis.com/auth/userinfo.profile"; );
-               $client->addScope( 
"https://www.googleapis.com/auth/userinfo.email"; );
+               $client->addScope( 'profile' );
+               $client->addScope( 'email' );
                return $client;
        }
 

-- 
To view, visit https://gerrit.wikimedia.org/r/275293
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iafa3e0c7342d2baf7bf4a31eddd88c5525ccb626
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/GoogleLogin
Gerrit-Branch: master
Gerrit-Owner: Florianschmidtwelzow <[email protected]>
Gerrit-Reviewer: Florianschmidtwelzow <[email protected]>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to