jenkins-bot has submitted this change and it was merged.

Change subject: Send failmail when TY job can't find contribution
......................................................................


Send failmail when TY job can't find contribution

This should come to our attention.

Bug: T131200
Change-Id: If2493a62b432fa7c1c1af2f47f2630fcc497066c
---
M sites/all/modules/thank_you/thank_you.module
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Awight: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/sites/all/modules/thank_you/thank_you.module 
b/sites/all/modules/thank_you/thank_you.module
index 8bb36eb..582777a 100644
--- a/sites/all/modules/thank_you/thank_you.module
+++ b/sites/all/modules/thank_you/thank_you.module
@@ -241,7 +241,8 @@
        // check that the API result is a valid contribution result
        if( !WMFCiviAPICheck::check_api_contribution( $contribution, 
$contribution_id ) ){
                // the API result is bad
-               watchdog('thank_you', 'Could not retrieve contribution record 
for: ' . $contribution_id . '<pre>' . print_r( $contribution, true ) . 
'</pre>', array(), WATCHDOG_ERROR);
+               $msg = 'Could not retrieve contribution record for: ' . 
$contribution_id . '<pre>' . print_r( $contribution, true ) . '</pre>';
+               wmf_common_failmail( 'thank_you', $msg );
                return false;
        }
        // go ahead and remove the extra layer of indirection to make it easier 
to use

-- 
To view, visit https://gerrit.wikimedia.org/r/280580
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If2493a62b432fa7c1c1af2f47f2630fcc497066c
Gerrit-PatchSet: 2
Gerrit-Project: wikimedia/fundraising/crm
Gerrit-Branch: master
Gerrit-Owner: Ejegg <[email protected]>
Gerrit-Reviewer: Awight <[email protected]>
Gerrit-Reviewer: Cdentinger <[email protected]>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to