jenkins-bot has submitted this change and it was merged.

Change subject: Move currencies to config
......................................................................


Move currencies to config

Except for Worldpay, so as not to further block
Icb3bc8e1f7b909ecf790efae3514e7af5763198a

Change-Id: I699b80fd28d0c093d025256b50f4cbbf2fed285d
---
M adyen_gateway/adyen.adapter.php
A adyen_gateway/config/currencies.yaml
M amazon_gateway/amazon.adapter.php
A amazon_gateway/config/currencies.yaml
M astropay_gateway/astropay.adapter.php
A astropay_gateway/config/currencies.yaml
M gateway_common/gateway.adapter.php
A globalcollect_gateway/config/currencies.yaml
M globalcollect_gateway/globalcollect.adapter.php
A paypal_gateway/config/currencies.yaml
M paypal_gateway/paypal.adapter.php
11 files changed, 331 insertions(+), 359 deletions(-)

Approvals:
  Awight: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/adyen_gateway/adyen.adapter.php b/adyen_gateway/adyen.adapter.php
index 3b5e30a..545387b 100644
--- a/adyen_gateway/adyen.adapter.php
+++ b/adyen_gateway/adyen.adapter.php
@@ -270,214 +270,6 @@
                return $transaction;
        }
 
-       public function getCurrencies( $options = array() ) {
-               // See 
http://www.adyen.com/platform/all-countries-all-currencies/
-               // This should be the list of all global "acceptance 
currencies".  Not
-               // finding that list, I've used everything for which we keep
-               // conversion rates.
-               // TODO: do we need to filter by country/method?
-               $currencies = array(
-                       'ADF', // Andorran Franc
-                       'ADP', // Andorran Peseta
-                       'AED', // Utd. Arab Emir. Dirham
-                       'AFA', // Afghanistan Afghani
-                       'AFN', // Afghanistan Afghani
-                       'ALL', // Albanian Lek
-                       'AMD', // Armenian Dram
-                       'ANG', // NL Antillian Guilder
-                       'AOA', // Angolan Kwanza
-                       'AON', // Angolan Old Kwanza
-                       'ARS', // Argentinian peso
-                       'ATS', // Austrian Schilling
-                       'AUD', // Australian Dollar
-                       'AWG', // Aruban Florin
-                       'AZM', // Azerbaijan Old Manat
-                       'AZN', // Azerbaijan New Manat
-                       'BAM', // Bosnian Mark
-                       'BBD', // Barbadian dollar
-                       'BDT', // Bangladeshi Taka
-                       'BEF', // Belgian Franc
-                       'BGL', // Bulgarian Old Lev
-                       'BGN', // Bulgarian Lev
-                       'BHD', // Bahraini Dinar
-                       'BIF', // Burundi Franc
-                       'BMD', // Bermudian Dollar
-                       'BND', // Brunei Dollar
-                       'BOB', // Bolivian Boliviano
-                       'BRL', // Brazilian Real
-                       'BSD', // Bahamian Dollar
-                       'BTN', // Bhutan Ngultrum
-                       'BWP', // Botswana Pula
-                       'BYR', // Belarusian Ruble
-                       'BZD', // Belize Dollar
-                       'CAD', // Canadian Dollar
-                       'CDF', // Congolese Franc
-                       'CHF', // Swiss Franc
-                       'CLP', // Chilean Peso
-                       'CNY', // Chinese Yuan Renminbi
-                       'COP', // Colombian Peso
-                       'CRC', // Costa Rican Colon
-                       'CUC', // Cuban Convertible Peso
-                       'CUP', // Cuban Peso
-                       'CVE', // Cape Verde Escudo
-                       'CYP', // Cyprus Pound
-                       'CZK', // Czech Koruna
-                       'DEM', // German Mark
-                       'DJF', // Djibouti Franc
-                       'DKK', // Danish Krone
-                       'DOP', // Dominican R. Peso
-                       'DZD', // Algerian Dinar
-                       'ECS', // Ecuador Sucre
-                       'EEK', // Estonian Kroon
-                       'EGP', // Egyptian Pound
-                       'ESP', // Spanish Peseta
-                       'ETB', // Ethiopian Birr
-                       'EUR', // Euro
-                       'FIM', // Finnish Markka
-                       'FJD', // Fiji Dollar
-                       'FKP', // Falkland Islands Pound
-                       'FRF', // French Franc
-                       'GBP', // British Pound
-                       'GEL', // Georgian Lari
-                       'GHC', // Ghanaian Cedi
-                       'GHS', // Ghanaian New Cedi
-                       'GIP', // Gibraltar Pound
-                       'GMD', // Gambian Dalasi
-                       'GNF', // Guinea Franc
-                       'GRD', // Greek Drachma
-                       'GTQ', // Guatemalan Quetzal
-                       'GYD', // Guyanese Dollar
-                       'HKD', // Hong Kong Dollar
-                       'HNL', // Honduran Lempira
-                       'HRK', // Croatian Kuna
-                       'HTG', // Haitian Gourde
-                       'HUF', // Hungarian Forint
-                       'IDR', // Indonesian Rupiah
-                       'IEP', // Irish Punt
-                       'ILS', // Israeli New Shekel
-                       'INR', // Indian Rupee
-                       'IQD', // Iraqi Dinar
-                       'IRR', // Iranian Rial
-                       'ISK', // Iceland Krona
-                       'ITL', // Italian Lira
-                       'JMD', // Jamaican Dollar
-                       'JOD', // Jordanian Dinar
-                       'JPY', // Japanese Yen
-                       'KES', // Kenyan Shilling
-                       'KGS', // Kyrgyzstanian Som
-                       'KHR', // Cambodian Riel
-                       'KMF', // Comoros Franc
-                       'KPW', // North Korean Won
-                       'KRW', // South Korean won
-                       'KWD', // Kuwaiti Dinar
-                       'KYD', // Cayman Islands Dollar
-                       'KZT', // Kazakhstani Tenge
-                       'LAK', // Lao Kip
-                       'LBP', // Lebanese Pound
-                       'LKR', // Sri Lankan Rupee
-                       'LRD', // Liberian Dollar
-                       'LSL', // Lesotho Loti
-                       'LTL', // Lithuanian Litas
-                       'LUF', // Luxembourg Franc
-                       'LVL', // Latvian Lats
-                       'LYD', // Libyan Dinar
-                       'MAD', // Moroccan Dirham
-                       'MDL', // Moldovan Leu
-                       'MGA', // Malagasy Ariary
-                       'MGF', // Malagasy Franc
-                       'MKD', // Macedonian Denar
-                       'MMK', // Myanmar Kyat
-                       'MNT', // Mongolian Tugrik
-                       'MOP', // Macau Pataca
-                       'MRO', // Mauritanian Ouguiya
-                       'MTL', // Maltese Lira
-                       'MUR', // Mauritius Rupee
-                       'MVR', // Maldive Rufiyaa
-                       'MWK', // Malawi Kwacha
-                       'MXN', // Mexican Peso
-                       'MYR', // Malaysian Ringgit
-                       'MZM', // Mozambique Metical
-                       'MZN', // Mozambique New Metical
-                       'NAD', // Namibia Dollar
-                       'NGN', // Nigerian Naira
-                       'NIO', // Nicaraguan Cordoba Oro
-                       'NLG', // Dutch Guilder
-                       'NOK', // Norwegian Kroner
-                       'NPR', // Nepalese Rupee
-                       'NZD', // New Zealand Dollar
-                       'OMR', // Omani Rial
-                       'PAB', // Panamanian Balboa
-                       'PEN', // Peruvian Nuevo Sol
-                       'PGK', // Papua New Guinea Kina
-                       'PHP', // Philippine Peso
-                       'PKR', // Pakistani Rupee
-                       'PLN', // Polish Złoty
-                       'PTE', // Portuguese Escudo
-                       'PYG', // Paraguay Guarani
-                       'QAR', // Qatari Rial
-                       'ROL', // Romanian Lei
-                       'RON', // Romanian New Lei
-                       'RSD', // Serbian Dinar
-                       'RUB', // Russian Rouble
-                       'RWF', // Rwandan Franc
-                       'SAR', // Saudi Riyal
-                       'SBD', // Solomon Islands Dollar
-                       'SCR', // Seychelles Rupee
-                       'SDD', // Sudanese Dinar
-                       'SDG', // Sudanese Pound
-                       'SDP', // Sudanese Old Pound
-                       'SEK', // Swedish Krona
-                       'SGD', // Singapore Dollar
-                       'SHP', // St. Helena Pound
-                       'SIT', // Slovenian Tolar
-                       'SKK', // Slovak Koruna
-                       'SLL', // Sierra Leone Leone
-                       'SOS', // Somali Shilling
-                       'SRD', // Suriname Dollar
-                       'SRG', // Suriname Guilder
-                       'STD', // Sao Tome/Principe Dobra
-                       'SVC', // El Salvador Colon
-                       'SYP', // Syrian Pound
-                       'SZL', // Swaziland Lilangeni
-                       'THB', // Thai Baht
-                       'TJS', // Tajikistani Somoni
-                       'TMM', // Turkmenistan Manat
-                       'TMT', // Turkmenistan New Manat
-                       'TND', // Tunisian Dinar
-                       'TOP', // Tonga Pa'anga
-                       'TRL', // Turkish Old Lira
-                       'TRY', // Turkish Lira
-                       'TTD', // Trinidad/Tobago Dollar
-                       'TWD', // New Taiwan dollar
-                       'TZS', // Tanzanian Shilling
-                       'UAH', // Ukrainian hryvnia
-                       'UGX', // Uganda Shilling
-                       'USD', // U.S. dollar
-                       'UYU', // Uruguayan Peso
-                       'UZS', // Uzbekistan Som
-                       'VEB', // Venezuelan Bolivar
-                       'VEF', // Venezuelan Bolivar Fuerte
-                       'VND', // Vietnamese Dong
-                       'VUV', // Vanuatu Vatu
-                       'WST', // Samoan Tala
-                       'XAF', // Central African CFA franc
-                       'XAG', // Silver (oz.)
-                       'XAU', // Gold (oz.)
-                       'XCD', // East Caribbean Dollar
-                       'XEU', // ECU
-                       'XOF', // West African CFA franc
-                       'XPD', // Palladium (oz.)
-                       'XPF', // CFP Franc
-                       'XPT', // Platinum (oz.)
-                       'YER', // Yemeni Rial
-                       'YUN', // Yugoslav Dinar
-                       'ZAR', // South African Rand
-                       'ZMK', // Zambian Kwacha
-                       'ZWD', // Zimbabwe Dollar
-               );
-               return $currencies;
-       }
-
        //@TODO: Determine why this is being overloaded here.
        //This looks like a var-renamed copy of the parent. :[
        protected function buildRequestParams() {
diff --git a/adyen_gateway/config/currencies.yaml 
b/adyen_gateway/config/currencies.yaml
new file mode 100644
index 0000000..fdef3c6
--- /dev/null
+++ b/adyen_gateway/config/currencies.yaml
@@ -0,0 +1,201 @@
+# See http://www.adyen.com/platform/all-countries-all-currencies/
+# This should be the list of all global "acceptance currencies".  Not
+# finding that list, I've used everything for which we keep
+# conversion rates.
+- ADF # Andorran Franc
+- ADP # Andorran Peseta
+- AED # Utd. Arab Emir. Dirham
+- AFA # Afghanistan Afghani
+- AFN # Afghanistan Afghani
+- ALL # Albanian Lek
+- AMD # Armenian Dram
+- ANG # NL Antillian Guilder
+- AOA # Angolan Kwanza
+- AON # Angolan Old Kwanza
+- ARS # Argentinian peso
+- ATS # Austrian Schilling
+- AUD # Australian Dollar
+- AWG # Aruban Florin
+- AZM # Azerbaijan Old Manat
+- AZN # Azerbaijan New Manat
+- BAM # Bosnian Mark
+- BBD # Barbadian dollar
+- BDT # Bangladeshi Taka
+- BEF # Belgian Franc
+- BGL # Bulgarian Old Lev
+- BGN # Bulgarian Lev
+- BHD # Bahraini Dinar
+- BIF # Burundi Franc
+- BMD # Bermudian Dollar
+- BND # Brunei Dollar
+- BOB # Bolivian Boliviano
+- BRL # Brazilian Real
+- BSD # Bahamian Dollar
+- BTN # Bhutan Ngultrum
+- BWP # Botswana Pula
+- BYR # Belarusian Ruble
+- BZD # Belize Dollar
+- CAD # Canadian Dollar
+- CDF # Congolese Franc
+- CHF # Swiss Franc
+- CLP # Chilean Peso
+- CNY # Chinese Yuan Renminbi
+- COP # Colombian Peso
+- CRC # Costa Rican Colon
+- CUC # Cuban Convertible Peso
+- CUP # Cuban Peso
+- CVE # Cape Verde Escudo
+- CYP # Cyprus Pound
+- CZK # Czech Koruna
+- DEM # German Mark
+- DJF # Djibouti Franc
+- DKK # Danish Krone
+- DOP # Dominican R. Peso
+- DZD # Algerian Dinar
+- ECS # Ecuador Sucre
+- EEK # Estonian Kroon
+- EGP # Egyptian Pound
+- ESP # Spanish Peseta
+- ETB # Ethiopian Birr
+- EUR # Euro
+- FIM # Finnish Markka
+- FJD # Fiji Dollar
+- FKP # Falkland Islands Pound
+- FRF # French Franc
+- GBP # British Pound
+- GEL # Georgian Lari
+- GHC # Ghanaian Cedi
+- GHS # Ghanaian New Cedi
+- GIP # Gibraltar Pound
+- GMD # Gambian Dalasi
+- GNF # Guinea Franc
+- GRD # Greek Drachma
+- GTQ # Guatemalan Quetzal
+- GYD # Guyanese Dollar
+- HKD # Hong Kong Dollar
+- HNL # Honduran Lempira
+- HRK # Croatian Kuna
+- HTG # Haitian Gourde
+- HUF # Hungarian Forint
+- IDR # Indonesian Rupiah
+- IEP # Irish Punt
+- ILS # Israeli New Shekel
+- INR # Indian Rupee
+- IQD # Iraqi Dinar
+- IRR # Iranian Rial
+- ISK # Iceland Krona
+- ITL # Italian Lira
+- JMD # Jamaican Dollar
+- JOD # Jordanian Dinar
+- JPY # Japanese Yen
+- KES # Kenyan Shilling
+- KGS # Kyrgyzstanian Som
+- KHR # Cambodian Riel
+- KMF # Comoros Franc
+- KPW # North Korean Won
+- KRW # South Korean won
+- KWD # Kuwaiti Dinar
+- KYD # Cayman Islands Dollar
+- KZT # Kazakhstani Tenge
+- LAK # Lao Kip
+- LBP # Lebanese Pound
+- LKR # Sri Lankan Rupee
+- LRD # Liberian Dollar
+- LSL # Lesotho Loti
+- LTL # Lithuanian Litas
+- LUF # Luxembourg Franc
+- LVL # Latvian Lats
+- LYD # Libyan Dinar
+- MAD # Moroccan Dirham
+- MDL # Moldovan Leu
+- MGA # Malagasy Ariary
+- MGF # Malagasy Franc
+- MKD # Macedonian Denar
+- MMK # Myanmar Kyat
+- MNT # Mongolian Tugrik
+- MOP # Macau Pataca
+- MRO # Mauritanian Ouguiya
+- MTL # Maltese Lira
+- MUR # Mauritius Rupee
+- MVR # Maldive Rufiyaa
+- MWK # Malawi Kwacha
+- MXN # Mexican Peso
+- MYR # Malaysian Ringgit
+- MZM # Mozambique Metical
+- MZN # Mozambique New Metical
+- NAD # Namibia Dollar
+- NGN # Nigerian Naira
+- NIO # Nicaraguan Cordoba Oro
+- NLG # Dutch Guilder
+- NOK # Norwegian Kroner
+- NPR # Nepalese Rupee
+- NZD # New Zealand Dollar
+- OMR # Omani Rial
+- PAB # Panamanian Balboa
+- PEN # Peruvian Nuevo Sol
+- PGK # Papua New Guinea Kina
+- PHP # Philippine Peso
+- PKR # Pakistani Rupee
+- PLN # Polish Złoty
+- PTE # Portuguese Escudo
+- PYG # Paraguay Guarani
+- QAR # Qatari Rial
+- ROL # Romanian Lei
+- RON # Romanian New Lei
+- RSD # Serbian Dinar
+- RUB # Russian Rouble
+- RWF # Rwandan Franc
+- SAR # Saudi Riyal
+- SBD # Solomon Islands Dollar
+- SCR # Seychelles Rupee
+- SDD # Sudanese Dinar
+- SDG # Sudanese Pound
+- SDP # Sudanese Old Pound
+- SEK # Swedish Krona
+- SGD # Singapore Dollar
+- SHP # St. Helena Pound
+- SIT # Slovenian Tolar
+- SKK # Slovak Koruna
+- SLL # Sierra Leone Leone
+- SOS # Somali Shilling
+- SRD # Suriname Dollar
+- SRG # Suriname Guilder
+- STD # Sao Tome/Principe Dobra
+- SVC # El Salvador Colon
+- SYP # Syrian Pound
+- SZL # Swaziland Lilangeni
+- THB # Thai Baht
+- TJS # Tajikistani Somoni
+- TMM # Turkmenistan Manat
+- TMT # Turkmenistan New Manat
+- TND # Tunisian Dinar
+- TOP # Tonga Paanga
+- TRL # Turkish Old Lira
+- TRY # Turkish Lira
+- TTD # Trinidad/Tobago Dollar
+- TWD # New Taiwan dollar
+- TZS # Tanzanian Shilling
+- UAH # Ukrainian hryvnia
+- UGX # Uganda Shilling
+- USD # U.S. dollar
+- UYU # Uruguayan Peso
+- UZS # Uzbekistan Som
+- VEB # Venezuelan Bolivar
+- VEF # Venezuelan Bolivar Fuerte
+- VND # Vietnamese Dong
+- VUV # Vanuatu Vatu
+- WST # Samoan Tala
+- XAF # Central African CFA franc
+- XAG # Silver (oz.)
+- XAU # Gold (oz.)
+- XCD # East Caribbean Dollar
+- XEU # ECU
+- XOF # West African CFA franc
+- XPD # Palladium (oz.)
+- XPF # CFP Franc
+- XPT # Platinum (oz.)
+- YER # Yemeni Rial
+- YUN # Yugoslav Dinar
+- ZAR # South African Rand
+- ZMK # Zambian Kwacha
+- ZWD # Zimbabwe Dollar
diff --git a/amazon_gateway/amazon.adapter.php 
b/amazon_gateway/amazon.adapter.php
index 8f043e0..5723382 100644
--- a/amazon_gateway/amazon.adapter.php
+++ b/amazon_gateway/amazon.adapter.php
@@ -421,13 +421,6 @@
                }
        }
 
-       public function getCurrencies( $options = array() ) {
-               // See 
https://payments.amazon.com/sdui/sdui/about?nodeId=73479#feat_countries
-               return array(
-                       'USD',
-               );
-       }
-
        /**
         * Override default behavior
         */
diff --git a/amazon_gateway/config/currencies.yaml 
b/amazon_gateway/config/currencies.yaml
new file mode 100644
index 0000000..fb1fcea
--- /dev/null
+++ b/amazon_gateway/config/currencies.yaml
@@ -0,0 +1,2 @@
+# See https://payments.amazon.com/sdui/sdui/about?nodeId=73479#feat_countries
+- USD
diff --git a/astropay_gateway/astropay.adapter.php 
b/astropay_gateway/astropay.adapter.php
index f1e60c2..027905b 100644
--- a/astropay_gateway/astropay.adapter.php
+++ b/astropay_gateway/astropay.adapter.php
@@ -339,22 +339,10 @@
                if ( !$country ) {
                        throw new InvalidArgumentException( 'Need to specify 
country if not yet set in unstaged data' );
                }
-               $currencies = array(
-                       'AR' => 'ARS', // Argentinian peso
-                       'BO' => 'BOB', // Bolivian Boliviano
-                       'BR' => 'BRL', // Brazilian Real
-                       'BZ' => 'BZD', // Belize Dollar
-                       'CL' => 'CLP', // Chilean Peso
-                       'CO' => 'COP', // Colombian Peso
-                       'MX' => 'MXN', // Mexican Peso
-                       'PE' => 'PEN', // Peruvian Nuevo Sol
-                       'US' => 'USD', // U.S. dollar
-                       'UY' => 'UYU', // Uruguayan Peso
-               );
-               if ( !isset( $currencies[$country] ) ) {
+               if ( !isset( $this->config['currencies'][$country] ) ) {
                        throw new OutOfBoundsException( "No supported 
currencies for $country" );
                }
-               return (array)$currencies[$country];
+               return (array)$this->config['currencies'][$country];
        }
 
        /**
diff --git a/astropay_gateway/config/currencies.yaml 
b/astropay_gateway/config/currencies.yaml
new file mode 100644
index 0000000..42d0cd5
--- /dev/null
+++ b/astropay_gateway/config/currencies.yaml
@@ -0,0 +1,10 @@
+AR: ARS # Argentinian peso
+BO: BOB # Bolivian Boliviano
+BR: BRL # Brazilian Real
+BZ: BZD # Belize Dollar
+CL: CLP # Chilean Peso
+CO: COP # Colombian Peso
+MX: MXN # Mexican Peso
+PE: PEN # Peruvian Nuevo Sol
+US: USD # U.S. dollar
+UY: UYU # Uruguayan Peso
diff --git a/gateway_common/gateway.adapter.php 
b/gateway_common/gateway.adapter.php
index dae98bd..0496e71 100644
--- a/gateway_common/gateway.adapter.php
+++ b/gateway_common/gateway.adapter.php
@@ -1195,6 +1195,10 @@
                return $this->payment_submethods;
        }
 
+       public function getCurrencies( $options = array() ) {
+               return $this->config['currencies'];
+       }
+
        /**
         * Sends a curl request to the gateway server, and gets a response.
         * Saves that response to the transaction_response's rawResponse;
diff --git a/globalcollect_gateway/config/currencies.yaml 
b/globalcollect_gateway/config/currencies.yaml
new file mode 100644
index 0000000..647c3cf
--- /dev/null
+++ b/globalcollect_gateway/config/currencies.yaml
@@ -0,0 +1,85 @@
+- AED # UAE dirham
+- ARS # Argentinian peso
+- AUD # Australian dollar
+- BBD # Barbadian dollar
+- BDT # Bagladesh taka
+- BGN # Bulgarian lev
+- BHD # Bahraini dinar
+- BMD # Bermudian dollar
+- BND # Brunei dollar
+- BOB # Bolivia boliviano
+- BRL # Brazilian real
+# - Removed temporarily for WellsFargo (28/06/13)                      - BSD # 
Bahamian dollar
+- BZD # Belize dollar
+- CAD # Canadian dollar
+- CHF # Swiss franc
+- CLP # Chilean deso
+- CNY # Chinese yuan renminbi
+- COP # Colombia columb
+- CRC # Costa Rican colon
+- CZK # Czech koruna
+- DKK # Danish krone
+- DOP # Dominican peso
+- DZD # Algerian dinar
+- EEK # Estonian kroon
+- EGP # Egyptian pound
+- EUR # Euro
+- GBP # British pound
+- GTQ # Guatemala quetzal
+- HKD # Hong Kong dollar
+- HNL # Honduras lempira
+- HRK # Croatian kuna
+- HUF # Hungarian forint
+- IDR # Indonesian rupiah
+- ILS # Israeli shekel
+- INR # Indian rupee
+- JMD # Jamaican dollar
+- JOD # Jordanian dinar
+- JPY # Japanese yen
+- KES # Kenyan shilling
+- KRW # South Korean won
+# - Removed temporarily for WellsFargo (28/06/13)                      - KYD # 
Cayman Islands dollar
+- KZT # Kazakhstani tenge
+- LBP # Lebanese pound
+- LKR # Sri Lankan rupee
+- LTL # Lithuanian litas
+- LVL # Latvian lats
+- MAD # Moroccan dirham
+- MKD # Macedonia denar
+- MUR # Mauritius rupee
+- MVR # Maldives rufiyaa
+- MXN # Mexican peso
+- MYR # Malaysian ringgit
+- NIO # Nicaragua Cordoba
+- NOK # Norwegian krone
+- NZD # New Zealand dollar
+- OMR # Omani rial
+- PAB # Panamanian balboa
+- PEN # Peru nuevo sol
+- PHP # Philippine peso
+- PKR # Pakistani rupee
+- PLN # Polish złoty
+# - Removed temporarily for WellsFargo (23/05/13)                      - PYG # 
Paraguayan guaraní
+- QAR # Qatari rial
+- RON # Romanian leu
+- RUB # Russian ruble
+- SAR # Saudi riyal
+- SEK # Swedish krona
+- SGD # Singapore dollar
+- SVC # Salvadoran colón
+- THB # Thai baht
+- TJS # Tajikistani Somoni
+- TND # Tunisan dinar
+- TRY # Turkish lira
+- TTD # Trinidad and Tobago dollar
+- TWD # New Taiwan dollar
+- UAH # Ukrainian hryvnia
+- UYU # Uruguayan peso
+- USD # U.S. dollar
+# - Removed temporarily for WellsFargo (28/06/13)                      - UZS # 
Uzbekistani som
+# - removed temporarily (Worldpay)                     - VND # Vietnamese dong
+- VEF # Venezuelan bolívar
+- XAF # Central African CFA franc
+- XCD # East Caribbean dollar
+# - Removed temporarily for WellsFargo (28/06/13)                      - XOF # 
West African CFA franc
+- ZAR # South African rand
diff --git a/globalcollect_gateway/globalcollect.adapter.php 
b/globalcollect_gateway/globalcollect.adapter.php
index 44f7149..cb46ece 100644
--- a/globalcollect_gateway/globalcollect.adapter.php
+++ b/globalcollect_gateway/globalcollect.adapter.php
@@ -1613,104 +1613,6 @@
        }
 
        /**
-        * Gets all the currency codes appropriate for this gateway
-        * @param array $options data to filter on
-        * @return array of currency codes
-        * TODO: filter on country/method using form settings
-        */
-       public function getCurrencies( $options = array() ) {
-               // If you update this list, also update the list in the 
exchange_rates drupal module.
-               $currencies = array(
-                       'AED', // UAE dirham
-                       'ARS', // Argentinian peso
-                       'AUD', // Australian dollar
-                       'BBD', // Barbadian dollar
-                       'BDT', // Bagladesh taka
-                       'BGN', // Bulgarian lev
-                       'BHD', // Bahraini dinar
-                       'BMD', // Bermudian dollar
-                       'BND', // Brunei dollar
-                       'BOB', // Bolivia boliviano
-                       'BRL', // Brazilian real
-// - Removed temporarily for WellsFargo (28/06/13)                     'BSD', 
// Bahamian dollar
-                       'BZD', // Belize dollar
-                       'CAD', // Canadian dollar
-                       'CHF', // Swiss franc
-                       'CLP', // Chilean deso
-                       'CNY', // Chinese yuan renminbi
-                       'COP', // Colombia columb
-                       'CRC', // Costa Rican colon
-                       'CZK', // Czech koruna
-                       'DKK', // Danish krone
-                       'DOP', // Dominican peso
-                       'DZD', // Algerian dinar
-                       'EEK', // Estonian kroon
-                       'EGP', // Egyptian pound
-                       'EUR', // Euro
-                       'GBP', // British pound
-                       'GTQ', // Guatemala quetzal
-                       'HKD', // Hong Kong dollar
-                       'HNL', // Honduras lempira
-                       'HRK', // Croatian kuna
-                       'HUF', // Hungarian forint
-                       'IDR', // Indonesian rupiah
-                       'ILS', // Israeli shekel
-                       'INR', // Indian rupee
-                       'JMD', // Jamaican dollar
-                       'JOD', // Jordanian dinar
-                       'JPY', // Japanese yen
-                       'KES', // Kenyan shilling
-                       'KRW', // South Korean won
-// - Removed temporarily for WellsFargo (28/06/13)                     'KYD', 
// Cayman Islands dollar
-                       'KZT', // Kazakhstani tenge
-                       'LBP', // Lebanese pound
-                       'LKR', // Sri Lankan rupee
-                       'LTL', // Lithuanian litas
-                       'LVL', // Latvian lats
-                       'MAD', // Moroccan dirham
-                       'MKD', // Macedonia denar
-                       'MUR', // Mauritius rupee
-                       'MVR', // Maldives rufiyaa
-                       'MXN', // Mexican peso
-                       'MYR', // Malaysian ringgit
-                       'NIO', // Nicaragua Cordoba
-                       'NOK', // Norwegian krone
-                       'NZD', // New Zealand dollar
-                       'OMR', // Omani rial
-                       'PAB', // Panamanian balboa
-                       'PEN', // Peru nuevo sol
-                       'PHP', // Philippine peso
-                       'PKR', // Pakistani rupee
-                       'PLN', // Polish złoty
-// - Removed temporarily for WellsFargo (23/05/13)                     'PYG', 
// Paraguayan guaraní
-                       'QAR', // Qatari rial
-                       'RON', // Romanian leu
-                       'RUB', // Russian ruble
-                       'SAR', // Saudi riyal
-                       'SEK', // Swedish krona
-                       'SGD', // Singapore dollar
-                       'SVC', // Salvadoran colón
-                       'THB', // Thai baht
-                       'TJS', // Tajikistani Somoni
-                       'TND', // Tunisan dinar
-                       'TRY', // Turkish lira
-                       'TTD', // Trinidad and Tobago dollar
-                       'TWD', // New Taiwan dollar
-                       'UAH', // Ukrainian hryvnia
-                       'UYU', // Uruguayan peso
-                       'USD', // U.S. dollar
-// - Removed temporarily for WellsFargo (28/06/13)                     'UZS', 
// Uzbekistani som
-// - removed temporarily (Worldpay)                    'VND', // Vietnamese 
dong
-                       'VEF', // Venezuelan bolívar
-                       'XAF', // Central African CFA franc
-                       'XCD', // East Caribbean dollar
-// - Removed temporarily for WellsFargo (28/06/13)                     'XOF', 
// West African CFA franc
-                       'ZAR', // South African rand
-               );
-               return $currencies;
-       }
-
-       /**
         * Process the response and set transaction_response properties
         *
         * @param DomDocument $response Cleaned-up XML from the GlobalCollect 
API
diff --git a/paypal_gateway/config/currencies.yaml 
b/paypal_gateway/config/currencies.yaml
new file mode 100644
index 0000000..51369e9
--- /dev/null
+++ b/paypal_gateway/config/currencies.yaml
@@ -0,0 +1,27 @@
+# see 
https://www.x.com/developers/paypal/documentation-tools/api/currency-codes
+# TODO: Investigate per-country support at this URL
+# https://developer.paypal.com/docs/classic/api/currency_codes/#creditcard
+- AUD
+# - BRL # in-country only... it seems to work but I'm respecting the docs
+- CAD
+- CZK
+- DKK
+- EUR
+- HKD
+- HUF
+- ILS
+- JPY # no fractions
+# - MYR # in-country only
+- MXN
+- NOK
+- NZD
+- PHP
+- PLN
+- GBP
+# - SGD # Only available for singaporian entities
+- SEK
+- CHF
+- TWD # no fractions
+- THB
+# - TRY # in-country only
+- USD
diff --git a/paypal_gateway/paypal.adapter.php 
b/paypal_gateway/paypal.adapter.php
index 5cbb053..dc2323b 100644
--- a/paypal_gateway/paypal.adapter.php
+++ b/paypal_gateway/paypal.adapter.php
@@ -228,36 +228,4 @@
                                return $result;
                }
        }
-
-       public function getCurrencies( $options = array() ) {
-               // see 
https://www.x.com/developers/paypal/documentation-tools/api/currency-codes
-               // TODO: Investigate per-country support at this URL
-               // 
https://developer.paypal.com/docs/classic/api/currency_codes/#creditcard
-               return array(
-                       'AUD',
-                       // 'BRL', // in-country only... it seems to work but 
I'm respecting the docs
-                       'CAD',
-                       'CZK',
-                       'DKK',
-                       'EUR',
-                       'HKD',
-                       'HUF',
-                       'ILS',
-                       'JPY', // no fractions
-                       // 'MYR', // in-country only
-                       'MXN',
-                       'NOK',
-                       'NZD',
-                       'PHP',
-                       'PLN',
-                       'GBP',
-                       /* 'SGD', // Only available for singaporian entities */
-                       'SEK',
-                       'CHF',
-                       'TWD', // no fractions
-                       'THB',
-                       // 'TRY', // in-country only
-                       'USD',
-               );
-       }
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/280776
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I699b80fd28d0c093d025256b50f4cbbf2fed285d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/DonationInterface
Gerrit-Branch: master
Gerrit-Owner: Ejegg <[email protected]>
Gerrit-Reviewer: AndyRussG <[email protected]>
Gerrit-Reviewer: Awight <[email protected]>
Gerrit-Reviewer: Cdentinger <[email protected]>
Gerrit-Reviewer: Ssmith <[email protected]>
Gerrit-Reviewer: XenoRyet <[email protected]>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to