Tinaj1234 has uploaded a new change for review.
https://gerrit.wikimedia.org/r/281300
Change subject: Better labels in Special:Newsletters
......................................................................
Better labels in Special:Newsletters
Improve labels of table headers in Special:Newsletters
Bug: T131680
Change-Id: I87693689e283d760e4eda5beaffda292672476a2
---
M i18n/en.json
M i18n/qqq.json
M includes/specials/pagers/NewsletterTablePager.php
3 files changed, 3 insertions(+), 5 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Newsletter
refs/changes/00/281300/1
diff --git a/i18n/en.json b/i18n/en.json
index be33eb2..a43b288 100755
--- a/i18n/en.json
+++ b/i18n/en.json
@@ -102,10 +102,9 @@
"newsletter-notification-link-text-view-newsletter": "View newsletter",
"newsletter-email-subject": "A new issue of $1 has been announced.",
"newsletter-email-batch-body": "$2 {{GENDER:$3|has announced}} a new
issue of $1.",
- "newsletter-header-name": "Name of newsletter",
+ "newsletter-header-name": "Name",
"newsletter-header-description": "Description",
- "newsletter-header-action": "Subscribed?",
- "newsletter-header-subscriber_count": "Subscriber count",
+ "newsletter-header-subscriber_count": "Subscribers",
"newsletter-delete-confirmation": "Are you sure you want to delete this
newsletter?",
"newsletter-delete-confirm-details": "Note that this action is not
reversible and data cannot be restored once it has been deleted.",
"newsletter-delete-confirm-cancel": "Cancel",
diff --git a/i18n/qqq.json b/i18n/qqq.json
index b928c3b..449b323 100644
--- a/i18n/qqq.json
+++ b/i18n/qqq.json
@@ -108,7 +108,6 @@
"newsletter-email-batch-body": "First line of the email body when a new
newsletter is announced Parameters:\n* $1 is the name of the newsletter.\n* $2
is the username of the user who announced the new issue, not used for GENDER\n*
$3 is the username of the user who announced the new issue, used for GENDER",
"newsletter-header-name": "Label of the newsletter name column of table
in [[Special:Newsletters]] which lists the names of newsletters",
"newsletter-header-description": "Label of the description column of
table in [[Special:Newsletters]] which displays a description about the
newsletter\n{{Identical|Description}}",
- "newsletter-header-action": "Label of the subscribe column of table in
[[Special:Newsletters]] which provides radio buttons to subscribe/unsubscribe
newsletters\n{{Identical|Subscribed}}",
"newsletter-header-subscriber_count": "Label of the subscriber count
column of table in [[Special:Newsletters]] which gives the subscriber count of
corresponding newsletter",
"newsletter-delete-confirmation": "Confirmation message shown when
attempting to delete a newsletter.",
"newsletter-delete-confirm-details": "Information message shown after
{{msg-mw|newsletter-delete-confirmation}}.",
diff --git a/includes/specials/pagers/NewsletterTablePager.php
b/includes/specials/pagers/NewsletterTablePager.php
index e115008..4c5abf5 100644
--- a/includes/specials/pagers/NewsletterTablePager.php
+++ b/includes/specials/pagers/NewsletterTablePager.php
@@ -34,7 +34,7 @@
if ( $this->getUser()->isLoggedIn() ) {
// Only logged-in users can (un)subscribe
- $this->fieldNames['action'] = $this->msg(
'newsletter-header-action' )->escaped();
+ $this->fieldNames['action'] = null;
}
}
--
To view, visit https://gerrit.wikimedia.org/r/281300
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I87693689e283d760e4eda5beaffda292672476a2
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Newsletter
Gerrit-Branch: master
Gerrit-Owner: Tinaj1234 <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
