Ejegg has uploaded a new change for review.
https://gerrit.wikimedia.org/r/281479
Change subject: Fix some PHPDoc comments
......................................................................
Fix some PHPDoc comments
Change-Id: If5c24787de194f95b80895038ad188235444a39a
---
M sites/all/modules/wmf_civicrm/wmf_civicrm.module
M sites/all/modules/wmf_common/Queue.php
M sites/all/modules/wmf_common/wmf_dates.php
3 files changed, 11 insertions(+), 4 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm
refs/changes/79/281479/1
diff --git a/sites/all/modules/wmf_civicrm/wmf_civicrm.module
b/sites/all/modules/wmf_civicrm/wmf_civicrm.module
index 291f74e..a53e116 100644
--- a/sites/all/modules/wmf_civicrm/wmf_civicrm.module
+++ b/sites/all/modules/wmf_civicrm/wmf_civicrm.module
@@ -1925,8 +1925,13 @@
* For refund events, mark the refund using our helper function.
*
* Raw gateway status is stored in a custom field.
+ * @param int $contribution_id
+ * @param string $raw_status
+ * @param string $normalized_status
+ * @param int $timestamp
+ * @throws WmfException
*/
-function wmf_civicrm_set_gateway_status( int $contribution_id, string
$raw_status, string $normalized_status = null, int $timestamp = null )
+function wmf_civicrm_set_gateway_status( $contribution_id, $raw_status,
$normalized_status = null, $timestamp = null )
{
civicrm_initialize();
diff --git a/sites/all/modules/wmf_common/Queue.php
b/sites/all/modules/wmf_common/Queue.php
index c9702c5..2804fc7 100644
--- a/sites/all/modules/wmf_common/Queue.php
+++ b/sites/all/modules/wmf_common/Queue.php
@@ -289,8 +289,8 @@
/**
* Enqueue a STOMP message
*
- * @param $msg Message to queue
- * @param $queue Queue to queue to; should start with /queue/
+ * @param array $msg Message to queue
+ * @param string $queue Queue to queue to; should start with /queue/
* @return bool True if STOMP claims it worked
*/
function enqueue( $msg, $properties, $queue ) {
diff --git a/sites/all/modules/wmf_common/wmf_dates.php
b/sites/all/modules/wmf_common/wmf_dates.php
index e38f208..ad4c4a1 100644
--- a/sites/all/modules/wmf_common/wmf_dates.php
+++ b/sites/all/modules/wmf_common/wmf_dates.php
@@ -46,7 +46,7 @@
* Get an array of all the valid dates between $start(exclusive) and
$end(inclusive)
* @param int $start Date string in the format yyyymmdd
* @param int $end Date string in the format yyyymmdd
- * @return An array of all date strings between the $start and $end values
+ * @return array all date strings between the $start and $end values
*/
function wmf_common_date_get_date_gap( $start, $end ){
$startdate = date_create_from_format(WMF_DATEFORMAT, (string)$start);
@@ -100,6 +100,7 @@
* Used to format dates for the CiviCRM API.
*
* @param string $unixtime unix timestamp in seconds since epoch
+ * @return string Formatted time
*/
function wmf_common_date_unix_to_civicrm( $unixtime ) {
return wmf_common_date_format_using_utc( "Y-m-d H:i:s", $unixtime );
@@ -109,6 +110,7 @@
* Used to format dates for MySQL datetime columns.
*
* @param string $unixtime unix timestamp in seconds since epoch
+ * @return string Formatted time
*/
function wmf_common_date_unix_to_sql( $unixtime ) {
return wmf_common_date_format_using_utc( "YmdHis", $unixtime );
--
To view, visit https://gerrit.wikimedia.org/r/281479
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If5c24787de194f95b80895038ad188235444a39a
Gerrit-PatchSet: 1
Gerrit-Project: wikimedia/fundraising/crm
Gerrit-Branch: master
Gerrit-Owner: Ejegg <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
