Krinkle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/281497
Change subject: webperf: Convert navtiming metric mapping into list
......................................................................
webperf: Convert navtiming metric mapping into list
Also alphabetize.
Change-Id: I063430a852fce50f0b448d3ab0fb64297451a14e
---
M modules/webperf/files/navtiming.py
1 file changed, 13 insertions(+), 13 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/operations/puppet
refs/changes/97/281497/1
diff --git a/modules/webperf/files/navtiming.py
b/modules/webperf/files/navtiming.py
index 08d381e..d4cfcd8 100755
--- a/modules/webperf/files/navtiming.py
+++ b/modules/webperf/files/navtiming.py
@@ -226,20 +226,20 @@
event = meta['event']
metrics = {}
- for metric, marker in (
- ('dnsLookup', 'dnsLookup'),
- ('loadEventStart', 'loadEventStart'),
- ('mediaWikiLoadStart', 'mediaWikiLoadStart'),
- ('mediaWikiLoadEnd', 'mediaWikiLoadEnd'),
- ('mediaWikiLoadComplete', 'mediaWikiLoadComplete'),
- ('redirecting', 'redirecting'),
- ('fetchStart', 'fetchStart'),
- ('loadEventEnd', 'loadEventEnd'),
- ('responseStart', 'responseStart'),
- ('firstPaint', 'firstPaint'),
+ for metric in (
+ 'dnsLookup',
+ 'fetchStart',
+ 'firstPaint',
+ 'loadEventEnd',
+ 'loadEventStart',
+ 'mediaWikiLoadComplete',
+ 'mediaWikiLoadEnd',
+ 'mediaWikiLoadStart',
+ 'redirecting',
+ 'responseStart',
):
- if marker in event:
- metrics[metric] = event[marker]
+ if metric in event:
+ metrics[metric] = event[metric]
for difference, minuend, subtrahend in (
('waiting', 'responseStart', 'requestStart'),
--
To view, visit https://gerrit.wikimedia.org/r/281497
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I063430a852fce50f0b448d3ab0fb64297451a14e
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Krinkle <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits