Ori.livneh has submitted this change and it was merged.
Change subject: webperf: Rename navtiming 'loading' and 'sending' to standard
equivalent
......................................................................
webperf: Rename navtiming 'loading' and 'sending' to standard equivalent
To match Coal. This allows better Grafana graphing and more consistent
in general. It also removes the last remaining rename in this list so that
this code can be simplified later navtiming.py be a list instead of a dict.
Change-Id: I9120bd0f4dc31b8f3b433a7e95b359e9b5b012ad
---
M modules/webperf/files/navtiming.py
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Ori.livneh: Verified; Looks good to me, approved
diff --git a/modules/webperf/files/navtiming.py
b/modules/webperf/files/navtiming.py
index 4bf1d6b..08d381e 100755
--- a/modules/webperf/files/navtiming.py
+++ b/modules/webperf/files/navtiming.py
@@ -228,12 +228,12 @@
for metric, marker in (
('dnsLookup', 'dnsLookup'),
- ('loading', 'loadEventStart'),
+ ('loadEventStart', 'loadEventStart'),
('mediaWikiLoadStart', 'mediaWikiLoadStart'),
('mediaWikiLoadEnd', 'mediaWikiLoadEnd'),
('mediaWikiLoadComplete', 'mediaWikiLoadComplete'),
('redirecting', 'redirecting'),
- ('sending', 'fetchStart'),
+ ('fetchStart', 'fetchStart'),
('loadEventEnd', 'loadEventEnd'),
('responseStart', 'responseStart'),
('firstPaint', 'firstPaint'),
--
To view, visit https://gerrit.wikimedia.org/r/281082
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9120bd0f4dc31b8f3b433a7e95b359e9b5b012ad
Gerrit-PatchSet: 4
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Krinkle <[email protected]>
Gerrit-Reviewer: Krinkle <[email protected]>
Gerrit-Reviewer: Ori.livneh <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
