Ori.livneh has submitted this change and it was merged.

Change subject: coal-web: Show domInteractive instead of domComplete
......................................................................


coal-web: Show domInteractive instead of domComplete

Per 0c38d0f, domInteractive is more useful and probably the one
that was intended.

* domInteractive is nicely half-way between responseStart and loadEvent.
  when the DOM is ready, but subresources have not finished loading.

* domComplete is almost the same as loadEvent. (99% there)
  They happen right after one another (one before, one after user
  event callback execution).

Change-Id: Iac7be04ebf762b1ce17eb1004020173e5c0659cc
---
M modules/coal/files/coal-web
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Ori.livneh: Verified; Looks good to me, approved



diff --git a/modules/coal/files/coal-web b/modules/coal/files/coal-web
index 2752b6c..d4056ad 100755
--- a/modules/coal/files/coal-web
+++ b/modules/coal/files/coal-web
@@ -39,7 +39,7 @@
 METRICS = (
     'responseStart',  # Time to user agent receiving first byte
     'firstPaint',     # Time to initial render
-    'domComplete',    # Time to DOM Comlete event
+    'domInteractive', # Time to DOM Ready event
     'loadEventEnd',   # Time to load event completion
     'saveTiming',     # Time to first byte for page edits
 )

-- 
To view, visit https://gerrit.wikimedia.org/r/281501
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iac7be04ebf762b1ce17eb1004020173e5c0659cc
Gerrit-PatchSet: 2
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Krinkle <[email protected]>
Gerrit-Reviewer: Ori.livneh <[email protected]>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to