jenkins-bot has submitted this change and it was merged.
Change subject: [bugfix] Enable -recentchanges without parameters
......................................................................
[bugfix] Enable -recentchanges without parameters
Test added
Bug: T131850
Change-Id: I87e8c27dec105e0b1a404ed4d5e2e2be1e7d442e
---
M pywikibot/pagegenerators.py
M tests/pagegenerators_tests.py
2 files changed, 9 insertions(+), 1 deletion(-)
Approvals:
John Vandenberg: Looks good to me, approved
jenkins-bot: Verified
diff --git a/pywikibot/pagegenerators.py b/pywikibot/pagegenerators.py
index 0c5f0a2..fdc4be9 100644
--- a/pywikibot/pagegenerators.py
+++ b/pywikibot/pagegenerators.py
@@ -688,7 +688,7 @@
elif arg == '-recentchanges':
rcstart = None
rcend = None
- params = value.split(',')
+ params = value.split(',') if value else []
if len(params) == 2:
offset = float(params[0])
duration = float(params[1])
diff --git a/tests/pagegenerators_tests.py b/tests/pagegenerators_tests.py
index 5adb054..f4f69f8 100755
--- a/tests/pagegenerators_tests.py
+++ b/tests/pagegenerators_tests.py
@@ -812,6 +812,14 @@
self.assertRaises(ValueError, gf.handleArg, '-recentchanges:3,2,1')
self.assertRaises(ValueError, gf.handleArg, '-recentchanges:-10,20')
+ def test_recentchanges_default(self):
+ """Test recentchanges generator with default setting."""
+ gf = pagegenerators.GeneratorFactory(site=self.site)
+ gf.handleArg('-recentchanges')
+ gen = gf.getCombinedGenerator()
+ self.assertIsNotNone(gen)
+ self.assertPagesInNamespacesAll(gen, set([0, 1, 2]), skip=True)
+
def test_recentchanges_ns_default(self):
"""Test recentchanges generator."""
gf = pagegenerators.GeneratorFactory(site=self.site)
--
To view, visit https://gerrit.wikimedia.org/r/281667
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I87e8c27dec105e0b1a404ed4d5e2e2be1e7d442e
Gerrit-PatchSet: 2
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: Xqt <[email protected]>
Gerrit-Reviewer: John Vandenberg <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
