Awight has uploaded a new change for review.
https://gerrit.wikimedia.org/r/281873
Change subject: WIP Move issuers into its own file
......................................................................
WIP Move issuers into its own file
Change-Id: Iae165a78cf343d0adff04dabe17e40b21f655811
---
A gateway_forms/mustache/ideal_issuers.html.mustache
M gateway_forms/mustache/payment_method.html.mustache
M globalcollect_gateway/config/payment_methods.yaml
3 files changed, 19 insertions(+), 17 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/DonationInterface
refs/changes/73/281873/1
diff --git a/gateway_forms/mustache/ideal_issuers.html.mustache
b/gateway_forms/mustache/ideal_issuers.html.mustache
new file mode 100644
index 0000000..cf1fe5b
--- /dev/null
+++ b/gateway_forms/mustache/ideal_issuers.html.mustache
@@ -0,0 +1,16 @@
+<select style="margin-top: 15px;" id="issuer_id" name="issuer_id" value="{{
issuer }}">
+ <option value="">{{ l10n "donate_interface-rtbt-issuer_id"
}}...</option>
+ <optgroup>
+ <option value="31">ABN AMRO</option>
+ <option value="721">ING</option>
+ <option value="21">Rabobank</option>
+ <option value="751">SNS Bank</option>
+ </optgroup>
+ <optgroup label="{{ l10n "donate_interface-rtbt-issuer_id-longlist" }}">
+ <option value="761">ASN Bank</option>
+ <option value="801">Knab</option>
+ <option value="771">RegioBank</option>
+ <option value="511">Triodos Bank</option>
+ <option value="161">Van Lanschot Bankiers</option>
+ </optgroup>
+</select>
diff --git a/gateway_forms/mustache/payment_method.html.mustache
b/gateway_forms/mustache/payment_method.html.mustache
index 435090f..d001497 100644
--- a/gateway_forms/mustache/payment_method.html.mustache
+++ b/gateway_forms/mustache/payment_method.html.mustache
@@ -23,22 +23,8 @@
</dd>
</dl>
{{# issuer_required }}
- <select
style="margin-top: 15px;" id="issuer_id" name="issuer_id" value="{{ issuer }}">
- <option
value="">{{ l10n "donate_interface-rtbt-issuer_id" }}...</option>
-
<optgroup>
-
<option value="31">ABN AMRO</option>
-
<option value="721">ING</option>
-
<option value="21">Rabobank</option>
-
<option value="751">SNS Bank</option>
-
</optgroup>
-
<optgroup label="%donate_interface-rtbt-issuer_id-longlist%">
-
<option value="761">ASN Bank</option>
-
<option value="801">Knab</option>
-
<option value="771">RegioBank</option>
-
<option value="511">Triodos Bank</option>
-
<option value="161">Van Lanschot Bankiers</option>
-
</optgroup>
- </select>
+{{! FIXME: support any type of issuer }}
+{{> ideal_issuers }}
{{/ issuer_required }}
<div
id="paymentContinue" {{^ show_submethods }}class="force"{{/ show_submethods }}>
<input class="btn enabled" id="paymentContinueBtn" type="button" value="{{ l10n
"donate_interface-continue" }}" /></div>
<div
id="paymentSubmit" > <input class="btn enabled" id="paymentSubmitBtn"
type="button" value="{{ l10n "donate_interface-submit-button" }}" /></div>
diff --git a/globalcollect_gateway/config/payment_methods.yaml
b/globalcollect_gateway/config/payment_methods.yaml
index e4e2ccb..fa30f1e 100644
--- a/globalcollect_gateway/config/payment_methods.yaml
+++ b/globalcollect_gateway/config/payment_methods.yaml
@@ -29,7 +29,7 @@
additional_success_status:
- 20
validation:
- issuer: true
+ issuer: true
cash:
label: 'Cash payments'
short_circuit_at: first_iop
--
To view, visit https://gerrit.wikimedia.org/r/281873
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iae165a78cf343d0adff04dabe17e40b21f655811
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/DonationInterface
Gerrit-Branch: master
Gerrit-Owner: Awight <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
