jenkins-bot has submitted this change and it was merged. Change subject: Have npm doc to install jsduck with bundler ......................................................................
Have npm doc to install jsduck with bundler The doc script relies on the rubygems jsduck which is most probably not installed. Add a 'predoc' script which npm will execute before 'doc' to get JSDuck installed from rubygems using bundler. Execute the JSDuck via bundler to get the proper dependencies. Bug: T109005 Bug: T130587 Signed-off-by: Antoine Musso <[email protected]> Change-Id: I8ea086cedd81c0cd626452b375a6ae1e81460943 --- M package.json 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Hashar: Looks good to me, approved jenkins-bot: Verified diff --git a/package.json b/package.json index edc135b..5dbaa01 100644 --- a/package.json +++ b/package.json @@ -2,7 +2,8 @@ "private": true, "scripts": { "test": "grunt test && npm run doc", - "doc": "jsduck" + "predoc": "bundle install", + "doc": "bundle exec jsduck" }, "dependencies": { "jsdoc": "<=3.3.0", -- To view, visit https://gerrit.wikimedia.org/r/281938 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8ea086cedd81c0cd626452b375a6ae1e81460943 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/MobileFrontend Gerrit-Branch: wmf/1.27.0-wmf.19 Gerrit-Owner: Hashar <[email protected]> Gerrit-Reviewer: Hashar <[email protected]> Gerrit-Reviewer: Paladox <[email protected]> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
