Bartosz Dziewoński has uploaded a new change for review.
https://gerrit.wikimedia.org/r/281943
Change subject: RadioSelectInputWidget: Don't try to reuse DOM when infusing
......................................................................
RadioSelectInputWidget: Don't try to reuse DOM when infusing
Follow-up to 498225dd9f6d44e65072c0832b3f19eb02a3c97f.
Bug: T131918
Change-Id: Iac1d93d21ad77ef032a09f0438460112cba44ac2
---
M src/widgets/InputWidget.js
M src/widgets/RadioSelectInputWidget.js
2 files changed, 15 insertions(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/oojs/ui refs/changes/43/281943/1
diff --git a/src/widgets/InputWidget.js b/src/widgets/InputWidget.js
index 1726c66..692f90d 100644
--- a/src/widgets/InputWidget.js
+++ b/src/widgets/InputWidget.js
@@ -87,9 +87,11 @@
*/
OO.ui.InputWidget.static.gatherPreInfuseState = function ( node, config ) {
var state = OO.ui.InputWidget.parent.static.gatherPreInfuseState( node,
config );
- state.value = config.$input.val();
- // Might be better in TabIndexedElement, but it's awkward to do there
because mixins are awkward
- state.focus = config.$input.is( ':focus' );
+ if ( config.$input && config.$input.length ) {
+ state.value = config.$input.val();
+ // Might be better in TabIndexedElement, but it's awkward to do
there because mixins are awkward
+ state.focus = config.$input.is( ':focus' );
+ }
return state;
};
diff --git a/src/widgets/RadioSelectInputWidget.js
b/src/widgets/RadioSelectInputWidget.js
index ea70b26..83d19a1 100644
--- a/src/widgets/RadioSelectInputWidget.js
+++ b/src/widgets/RadioSelectInputWidget.js
@@ -65,6 +65,16 @@
return state;
};
+/**
+ * @inheritdoc
+ */
+OO.ui.RadioSelectInputWidget.static.reusePreInfuseDOM = function ( node,
config ) {
+ config = OO.ui.RadioSelectInputWidget.parent.static.reusePreInfuseDOM(
node, config );
+ // Cannot reuse the `<input type=radio>` set
+ delete config.$input;
+ return config;
+};
+
/* Methods */
/**
--
To view, visit https://gerrit.wikimedia.org/r/281943
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iac1d93d21ad77ef032a09f0438460112cba44ac2
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
