[MediaWiki-commits] [Gerrit] [Index: pages form] Set input type=number only if the existi... - change (mediawiki...ProofreadPage)

[Tpt (Code Review)]

Tpt has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/282138

Change subject: [Index: pages form] Set input type=number only if the existing 
value type is actually a number
......................................................................

[Index: pages form] Set input type=number only if the existing value type is 
actually a number

This will avoid looses of dates when editing with Chrome that removes the 
invalid number on load

Change-Id: I2581ff031eb08dbb6be5e773ff31a16882eb9d34
---
M includes/index/EditProofreadIndexPage.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ProofreadPage 
refs/changes/38/282138/1

diff --git a/includes/index/EditProofreadIndexPage.php 
b/includes/index/EditProofreadIndexPage.php
index c6936ea..e97db7b 100644
--- a/includes/index/EditProofreadIndexPage.php
+++ b/includes/index/EditProofreadIndexPage.php
@@ -94,7 +94,7 @@
                        $out->addHTML( $select->getHtml() );
                } else {
                        $type = $entry->getType();
-                       $inputType = ( $type === 'number' ) ? 'number' : 'text';
+                       $inputType = ( $type === 'number' && ( $val === '' || 
is_numeric( $val ) ) ) ? 'number' : 'text';
                        $size = $entry->getSize();
                        $inputAttributes['class'] = 'prp-input-' . $type;
 

-- 
To view, visit https://gerrit.wikimedia.org/r/282138
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2581ff031eb08dbb6be5e773ff31a16882eb9d34
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ProofreadPage
Gerrit-Branch: master
Gerrit-Owner: Tpt <thoma...@hotmail.fr>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits