Aude has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/282144

Change subject: Set only title text in ParserOutput (and not display title 
property)
......................................................................

Set only title text in ParserOutput (and not display title property)

This page prop doesn't handle multilingual content and will store
the title in only one language. This causes problems in places like
Special:Nearby when a nearby item has no label in one's user language.

Bug: T120197
Change-Id: I05ad7326982d98dc77181185cfa26ee22124b94e
---
M repo/includes/ParserOutput/EntityParserOutputGenerator.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase 
refs/changes/44/282144/1

diff --git a/repo/includes/ParserOutput/EntityParserOutputGenerator.php 
b/repo/includes/ParserOutput/EntityParserOutputGenerator.php
index 96e8459..4bc412d 100644
--- a/repo/includes/ParserOutput/EntityParserOutputGenerator.php
+++ b/repo/includes/ParserOutput/EntityParserOutputGenerator.php
@@ -273,7 +273,7 @@
 
                // Set the display title to display the label together with the 
item's id
                $titleHtml = $entityView->getTitleHtml( $entity );
-               $parserOutput->setDisplayTitle( $titleHtml );
+               $parserOutput->setTitleText( $titleHtml );
 
                $html = $entityView->getHtml( $entity );
                $parserOutput->setText( $html );

-- 
To view, visit https://gerrit.wikimedia.org/r/282144
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I05ad7326982d98dc77181185cfa26ee22124b94e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Aude <aude.w...@gmail.com>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to