jenkins-bot has submitted this change and it was merged.
Change subject: Mark some functions as static because RandomGameUnit assumes
they are such
......................................................................
Mark some functions as static because RandomGameUnit assumes they are such
Change-Id: I71a3fe76868579c417e4ba0d9ef96c9239c7d45e
---
M PollClass.php
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Jack Phoenix: Looks good to me, approved
jenkins-bot: Verified
diff --git a/PollClass.php b/PollClass.php
index 59bc884..89e1a45 100644
--- a/PollClass.php
+++ b/PollClass.php
@@ -141,7 +141,7 @@
$poll['id'] = $row->poll_id;
$poll['status'] = $row->poll_status;
$poll['timestamp'] = $row->timestamp;
- $poll['choices'] = $this->getPollChoices(
$row->poll_id, $row->poll_vote_count );
+ $poll['choices'] = self::getPollChoices( $row->poll_id,
$row->poll_vote_count );
}
return $poll;
}
@@ -154,7 +154,7 @@
* @return Array: poll answer choice info (answer ID, text,
* amount of votes and percent of
total votes)
*/
- public function getPollChoices( $poll_id, $poll_vote_count = 0 ) {
+ public static function getPollChoices( $poll_id, $poll_vote_count = 0 )
{
global $wgLang;
$dbr = wfGetDB( DB_SLAVE );
@@ -325,7 +325,7 @@
* @param $count Integer: how many polls to fetch? Default is 3.
* @param $order String: ORDER BY for SQL query, default being
'poll_id'.
*/
- public function getPollList( $count = 3, $order = 'poll_id' ) {
+ public static function getPollList( $count = 3, $order = 'poll_id' ) {
global $wgMemc;
$polls = array();
--
To view, visit https://gerrit.wikimedia.org/r/282342
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I71a3fe76868579c417e4ba0d9ef96c9239c7d45e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/PollNY
Gerrit-Branch: master
Gerrit-Owner: Jack Phoenix <[email protected]>
Gerrit-Reviewer: Jack Phoenix <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
