jenkins-bot has submitted this change and it was merged. Change subject: Pass lazy load image cookie value to NavigationTiming schema ......................................................................
Pass lazy load image cookie value to NavigationTiming schema * Allow us to distinguish pages where images are lazy loaded and where they are not. * Remove no longer used NetSpeed cookie. * Changes bundled into one change to avoid 2 schema changes. See https://meta.wikimedia.org/w/index.php?diff=15485142 Bug: T127883 Change-Id: Ibeb9be7d7e5d3180711e999064c3733a45b0a0c8 --- M extension.json M modules/ext.navigationTiming.js 2 files changed, 4 insertions(+), 4 deletions(-) Approvals: Krinkle: Looks good to me, but someone else must approve Phuedx: Looks good to me, approved jenkins-bot: Verified diff --git a/extension.json b/extension.json index fdce637..512e8c3 100644 --- a/extension.json +++ b/extension.json @@ -48,7 +48,7 @@ ] }, "EventLoggingSchemas": { - "NavigationTiming": 15396488, + "NavigationTiming": 15485142, "SaveTiming": 15396492 }, "config": { diff --git a/modules/ext.navigationTiming.js b/modules/ext.navigationTiming.js index 737e25d..4f38e99 100644 --- a/modules/ext.navigationTiming.js +++ b/modules/ext.navigationTiming.js @@ -126,10 +126,10 @@ }, isSpecialPage = !!mw.config.get( 'wgCanonicalSpecialPageName' ), mobileMode = mw.config.get( 'wgMFMode' ), - netSpeed = $.cookie( 'NetSpeed' ); + lazyLoadImages = $.cookie( 'mfLazyLoadImages' ); - if ( netSpeed === 'A' || netSpeed === 'B' || netSpeed === 'C' ) { - event.netSpeed = netSpeed; + if ( lazyLoadImages === 'A' || lazyLoadImages === 'B' || lazyLoadImages === 'C' ) { + event.lazyLoadImages = lazyLoadImages; } if ( window.mediaWikiLoadStart ) { -- To view, visit https://gerrit.wikimedia.org/r/280354 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibeb9be7d7e5d3180711e999064c3733a45b0a0c8 Gerrit-PatchSet: 6 Gerrit-Project: mediawiki/extensions/NavigationTiming Gerrit-Branch: master Gerrit-Owner: Jdlrobson <[email protected]> Gerrit-Reviewer: Krinkle <[email protected]> Gerrit-Reviewer: Ori.livneh <[email protected]> Gerrit-Reviewer: Phuedx <[email protected]> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
