jenkins-bot has submitted this change and it was merged.
Change subject: Narrow grunt jshint scope to js development folders
......................................................................
Narrow grunt jshint scope to js development folders
Currently, when running grunt, the jshint step chokes on the Grunt-
generated JavaScript in app/src/main/assets. The check should be
confined to the folders where we actually do our JS development.
Change-Id: I8939e1b9e3b53eb084fdac18aee858e9c87805df
---
M www/Gruntfile.js
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Niedzielski: Looks good to me, approved
jenkins-bot: Verified
diff --git a/www/Gruntfile.js b/www/Gruntfile.js
index 2af1305..70153ec 100644
--- a/www/Gruntfile.js
+++ b/www/Gruntfile.js
@@ -37,8 +37,8 @@
jshintrc: true
},
all: [
- '../*.js',
- '**/*.js',
+ 'js/*.js',
+ 'js/transforms/*.js',
'!node_modules/**',
'!lib/**'
]
--
To view, visit https://gerrit.wikimedia.org/r/281948
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8939e1b9e3b53eb084fdac18aee858e9c87805df
Gerrit-PatchSet: 3
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Mholloway <[email protected]>
Gerrit-Reviewer: BearND <[email protected]>
Gerrit-Reviewer: Brion VIBBER <[email protected]>
Gerrit-Reviewer: Dbrant <[email protected]>
Gerrit-Reviewer: Mholloway <[email protected]>
Gerrit-Reviewer: Niedzielski <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
