jenkins-bot has submitted this change and it was merged.
Change subject: Removed drilldown filtering for more field types
......................................................................
Removed drilldown filtering for more field types
Change-Id: I34d6450c2611294163268f5b41bb26b59cc2be64
---
M drilldown/CargoSpecialDrilldown.php
1 file changed, 1 insertion(+), 4 deletions(-)
Approvals:
Yaron Koren: Checked; Looks good to me, approved
jenkins-bot: Verified
diff --git a/drilldown/CargoSpecialDrilldown.php
b/drilldown/CargoSpecialDrilldown.php
index 79dad14..1f478a3 100644
--- a/drilldown/CargoSpecialDrilldown.php
+++ b/drilldown/CargoSpecialDrilldown.php
@@ -978,10 +978,7 @@
foreach ( $tableSchema->mFieldDescriptions as $fieldName =>
$fieldDescription ) {
$fieldType = $fieldDescription->mType;
// Some field types shouldn't get a filter at all.
- if ( in_array( $fieldType, array( 'URL', 'Wikitext' ) )
) {
- continue;
- } elseif ( $fieldType == 'Text' &&
$fieldDescription->mSize != null &&
- $fieldDescription->mSize > 100 ) {
+ if ( in_array( $fieldType, array( 'Text', 'URL',
'Wikitext', 'Searchtext' ) ) ) {
continue;
}
$f = new CargoFilter();
--
To view, visit https://gerrit.wikimedia.org/r/282409
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I34d6450c2611294163268f5b41bb26b59cc2be64
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Cargo
Gerrit-Branch: master
Gerrit-Owner: Yaron Koren <yaro...@gmail.com>
Gerrit-Reviewer: Yaron Koren <yaro...@gmail.com>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
