jenkins-bot has submitted this change and it was merged.
Change subject: FooterNoticeWidget: Set image height explicitly
......................................................................
FooterNoticeWidget: Set image height explicitly
If we don't do this, the footer becomes slightly taller
when the image loads, which makes the popup clip incorrectly.
Change-Id: Ica84d704692676d884b847f8fe01c49319f04931
---
M modules/ooui/mw.echo.ui.FooterNoticeWidget.js
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Mattflaschen: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/ooui/mw.echo.ui.FooterNoticeWidget.js
b/modules/ooui/mw.echo.ui.FooterNoticeWidget.js
index dbffd5c..e34f2bc 100644
--- a/modules/ooui/mw.echo.ui.FooterNoticeWidget.js
+++ b/modules/ooui/mw.echo.ui.FooterNoticeWidget.js
@@ -23,7 +23,7 @@
if ( config.iconUrl ) {
$icon = $( '<div>' )
.addClass( 'mw-echo-ui-footerNoticeWidget-icon'
)
- .append( $( '<img>' ).attr( 'src',
config.iconUrl ) );
+ .append( $( '<img>' ).attr( { src:
config.iconUrl, width: 30, height: 30 } ) );
$row.append( $icon );
}
--
To view, visit https://gerrit.wikimedia.org/r/282444
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ica84d704692676d884b847f8fe01c49319f04931
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Echo
Gerrit-Branch: master
Gerrit-Owner: Catrope <roan.katt...@gmail.com>
Gerrit-Reviewer: Mattflaschen <mflasc...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
