[MediaWiki-commits] [Gerrit] Hygiene: add parameters to raw types - change (apps...wikipedia)

[Niedzielski (Code Review)]

Niedzielski has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/282487

Change subject: Hygiene: add parameters to raw types
......................................................................

Hygiene: add parameters to raw types

Change-Id: If5c595e6c30dbe4ce32aae4e0cc8466f9d20a1d7
---
M app/src/main/java/org/wikipedia/ParcelableLruCache.java
1 file changed, 14 insertions(+), 9 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia 
refs/changes/87/282487/1

diff --git a/app/src/main/java/org/wikipedia/ParcelableLruCache.java 
b/app/src/main/java/org/wikipedia/ParcelableLruCache.java
index aca4b2c..988c39f 100644
--- a/app/src/main/java/org/wikipedia/ParcelableLruCache.java
+++ b/app/src/main/java/org/wikipedia/ParcelableLruCache.java
@@ -21,13 +21,13 @@
  *
  * V can either be a String, Parcelable or a List<Parcelable>
  */
-public class ParcelableLruCache<V> extends LruCache<String, V>  implements 
Parcelable {
+public class ParcelableLruCache<V> extends LruCache<String, V> implements 
Parcelable {
     private static final int TYPE_LIST = 1;
     private static final int TYPE_PARCELABLE = 2;
     private static final int TYPE_STRING = 3;
 
     private final int type;
-    public ParcelableLruCache(int maxSize, Class valueClass) {
+    public ParcelableLruCache(int maxSize, Class<?> valueClass) {
         super(maxSize);
         if (valueClass.equals(String.class)) {
             type = TYPE_STRING;
@@ -47,12 +47,15 @@
         for (String key : keys) {
             switch (type) {
                 case TYPE_LIST:
+                    //noinspection unchecked
                     put(key, (V) contents.getParcelableArrayList(key));
                     break;
                 case TYPE_PARCELABLE:
+                    //noinspection unchecked
                     put(key, (V) contents.getParcelable(key));
                     break;
                 case TYPE_STRING:
+                    //noinspection unchecked
                     put(key, (V) contents.getString(key));
                     break;
                 default:
@@ -75,7 +78,9 @@
         for (Map.Entry<String, V> entry : snapshot.entrySet()) {
             switch (type) {
                 case TYPE_LIST:
-                    bundle.putParcelableArrayList(entry.getKey(), 
(ArrayList)entry.getValue());
+                    //noinspection unchecked
+                    bundle.putParcelableArrayList(entry.getKey(),
+                            (ArrayList<? extends Parcelable>) 
entry.getValue());
                     break;
                 case TYPE_PARCELABLE:
                     bundle.putParcelable(entry.getKey(), (Parcelable) 
entry.getValue());
@@ -90,16 +95,16 @@
         dest.writeBundle(bundle);
     }
 
-    public static final Parcelable.Creator<ParcelableLruCache> CREATOR
-            = new Parcelable.Creator<ParcelableLruCache>() {
+    public static final Parcelable.Creator<ParcelableLruCache<?>> CREATOR
+            = new Parcelable.Creator<ParcelableLruCache<?>>() {
         @Override
-        public ParcelableLruCache createFromParcel(Parcel in) {
-            return new ParcelableLruCache(in);
+        public ParcelableLruCache<?> createFromParcel(Parcel in) {
+            return new ParcelableLruCache<>(in);
         }
 
         @Override
-        public ParcelableLruCache[] newArray(int size) {
-            return new ParcelableLruCache[size];
+        public ParcelableLruCache<?>[] newArray(int size) {
+            return new ParcelableLruCache<?>[size];
         }
     };
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/282487
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If5c595e6c30dbe4ce32aae4e0cc8466f9d20a1d7
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Niedzielski <sniedziel...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits