jenkins-bot has submitted this change and it was merged.

Change subject: [doc] Remove template documentation which is not very helpful 
here
......................................................................


[doc] Remove template documentation which is not very helpful here

Also move replacements instantiating where it is needed.

Change-Id: I78d30fc0642934bfa5aa8b9e48a8d875461881e1
---
M scripts/image.py
1 file changed, 1 insertion(+), 8 deletions(-)

Approvals:
  John Vandenberg: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/scripts/image.py b/scripts/image.py
index c826178..81ec66d 100755
--- a/scripts/image.py
+++ b/scripts/image.py
@@ -131,14 +131,6 @@
                 else self.old_image,
                 fallback=True)
 
-        # regular expression to find the original template.
-        # {{vfd}} does the same thing as {{Vfd}}, so both will be found.
-        # The old syntax, {{msg:vfd}}, will also be found.
-        # The group 'parameters' will either match the parameters, or an
-        # empty string if there are none.
-
-        replacements = []
-
         namespace = self.site.namespaces[6]
         if namespace.case == 'first-letter':
             case = re.escape(self.old_image[0].upper() +
@@ -156,6 +148,7 @@
         else:
             image_regex = re.compile(r'' + escaped)
 
+        replacements = []
         if self.new_image:
             if not self.getOption('loose'):
                 replacements.append((image_regex,

-- 
To view, visit https://gerrit.wikimedia.org/r/282199
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I78d30fc0642934bfa5aa8b9e48a8d875461881e1
Gerrit-PatchSet: 3
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: Xqt <i...@gno.de>
Gerrit-Reviewer: John Vandenberg <jay...@gmail.com>
Gerrit-Reviewer: Mpaa <mpaa.w...@gmail.com>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to