Zfilipin has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/282709

Change subject: Make site-specific Cucumber tag optional
......................................................................

Make site-specific Cucumber tag optional

Core does not have any site-specific Cucumber tags. To make it possible
to run it’s Cucumber/Selenium tests in Jenkins, `site_tag: false` is
used:

    MediawikiSelenium::RakeTask.new(site_tag: false)

Bug: T128190
Change-Id: I73f43740606ad85c61271c963fde5d39ed3a159f
---
M lib/mediawiki_selenium/rake_task.rb
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/selenium 
refs/changes/09/282709/1

diff --git a/lib/mediawiki_selenium/rake_task.rb 
b/lib/mediawiki_selenium/rake_task.rb
index db15992..b8ef596 100644
--- a/lib/mediawiki_selenium/rake_task.rb
+++ b/lib/mediawiki_selenium/rake_task.rb
@@ -4,7 +4,7 @@
 
 module MediawikiSelenium
   class RakeTask < Cucumber::Rake::Task
-    def initialize(name = :selenium, test_dir: 
Environment.default_test_directory)
+    def initialize(name: :selenium, test_dir: 
Environment.default_test_directory, site_tag: true)
       target = File.expand_path(test_dir, Rake.original_dir)
       env = Environment.load_default(target)
 
@@ -19,7 +19,7 @@
           ' --backtrace --verbose --color --format pretty'\
           " --format Cucumber::Formatter::Sauce --out 
'#{workspace}/log/junit'"\
           ' --tags ~@skip'\
-          " --tags @#{site}"
+          " --tags @#{site}" if site_tag
       end
 
       super(name) do |t|

-- 
To view, visit https://gerrit.wikimedia.org/r/282709
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I73f43740606ad85c61271c963fde5d39ed3a159f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/selenium
Gerrit-Branch: master
Gerrit-Owner: Zfilipin <zfili...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to