jenkins-bot has submitted this change and it was merged.
Change subject: Cache first-letter data in APC, if available
......................................................................
Cache first-letter data in APC, if available
I noticed that `frwiki:first-letters:fr:fr:4.8.1.1` was at the very top of keys
sorted by bandwidth (that is, reqs/sec * size) on one of the memcache servers
on WMF prod.
The data takes ~60 - 80ms to compute, in case of a cache miss. That's not
enough to justify using a tiered cache abstraction here, IMO.
Change-Id: If81ce8f86f2c378565f1f6a0dd2c04dee825c4e9
---
M includes/collation/IcuCollation.php
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
MaxSem: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/collation/IcuCollation.php
b/includes/collation/IcuCollation.php
index 0aa1406..942036b 100644
--- a/includes/collation/IcuCollation.php
+++ b/includes/collation/IcuCollation.php
@@ -240,8 +240,8 @@
return $this->firstLetterData;
}
- $cache = wfGetCache( CACHE_ANYTHING );
- $cacheKey = wfMemcKey(
+ $cache = ObjectCache::getLocalServerInstance( CACHE_ANYTHING );
+ $cacheKey = $cache->makeKey(
'first-letters',
$this->locale,
$this->digitTransformLanguage->getCode(),
--
To view, visit https://gerrit.wikimedia.org/r/282833
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If81ce8f86f2c378565f1f6a0dd2c04dee825c4e9
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Ori.livneh <[email protected]>
Gerrit-Reviewer: MaxSem <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
