Ori.livneh has uploaded a new change for review.
https://gerrit.wikimedia.org/r/282986
Change subject: Don't report image cache hits / misses
......................................................................
Don't report image cache hits / misses
This single metric is responsible for a substantial proportion of overall
statsd traffic on the Wikimedia cluster, per the task cited below. Nobody is
closely monitoring this statistic. We can reintroduce it with sampling at a
later date if it is deemed to be useful.
Bug: T101141
Change-Id: I6457cb91d527ce42c0918ac4e80613e6b59061ac
---
M includes/filerepo/file/LocalFile.php
1 file changed, 0 insertions(+), 6 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/86/282986/1
diff --git a/includes/filerepo/file/LocalFile.php
b/includes/filerepo/file/LocalFile.php
index 9677f5d..40b2226 100644
--- a/includes/filerepo/file/LocalFile.php
+++ b/includes/filerepo/file/LocalFile.php
@@ -267,12 +267,6 @@
}
}
- if ( $this->dataLoaded ) {
- wfIncrStats( 'image_cache.hit' );
- } else {
- wfIncrStats( 'image_cache.miss' );
- }
-
return $this->dataLoaded;
}
--
To view, visit https://gerrit.wikimedia.org/r/282986
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6457cb91d527ce42c0918ac4e80613e6b59061ac
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Ori.livneh <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
