Daniel Werner has submitted this change and it was merged. Change subject: Making remove button state changeable ......................................................................
Making remove button state changeable This is actually a remainder of when the remove button was independent from edit mode which made the remove button's state (enabled/disabled) to not be affected by changing the overall toolbar state. Since the remove button does show up in edit mode only, now, it should be treated just like the other buttons. Change-Id: I7a96f573e561d4bf53b852275c60b6115dc139e3 --- M lib/resources/wikibase.ui.Toolbar.EditGroup.js M lib/tests/qunit/wikibase.ui.PropertyEditTool.EditableValue.tests.js 2 files changed, 14 insertions(+), 6 deletions(-) Approvals: Daniel Werner: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/44394 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7a96f573e561d4bf53b852275c60b6115dc139e3 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Henning Snater <henning.sna...@wikimedia.de> Gerrit-Reviewer: Daniel Werner <daniel.wer...@wikimedia.de> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits