Xqt has uploaded a new change for review.
https://gerrit.wikimedia.org/r/283600
Change subject: [IMPR] Simplify arg parsing
......................................................................
[IMPR] Simplify arg parsing
Change-Id: I622940692b0649823a1ff178deaf3535dcb4f8a2
---
M scripts/listpages.py
1 file changed, 14 insertions(+), 14 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/pywikibot/core
refs/changes/00/283600/1
diff --git a/scripts/listpages.py b/scripts/listpages.py
index f64e026..cac334d 100755
--- a/scripts/listpages.py
+++ b/scripts/listpages.py
@@ -191,25 +191,25 @@
genFactory = GeneratorFactory()
for arg in local_args:
+ arg, sep, value = arg.partition(':')
if arg == '-notitle':
notitle = True
- elif arg.startswith('-format:'):
- fmt = arg[len('-format:'):]
- fmt = fmt.replace(u'\\03{{', u'\03{{')
- elif arg.startswith('-outputlang:'):
- outputlang = arg[len('-outputlang:'):]
+ elif arg == '-format':
+ fmt = value.replace(u'\\03{{', u'\03{{')
+ elif arg == '-outputlang:':
+ outputlang = value
elif arg == '-get':
page_get = True
- elif arg.startswith('-save'):
- base_dir = arg.partition(':')[2] or '.'
- elif arg.startswith('-encode:'):
- encoding = arg.partition(':')[2]
- elif arg.startswith('-put:'):
- page_target = arg.partition(':')[2]
- elif arg.startswith('-overwrite'):
+ elif arg == '-save':
+ base_dir = value or '.'
+ elif arg == '-encode':
+ encoding = value
+ elif arg == '-put':
+ page_target = value
+ elif arg == '-overwrite':
overwrite = True
- elif arg.startswith('-summary:'):
- summary = arg.partition(':')[2]
+ elif arg == '-summary':
+ summary = value
else:
genFactory.handleArg(arg)
--
To view, visit https://gerrit.wikimedia.org/r/283600
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I622940692b0649823a1ff178deaf3535dcb4f8a2
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: Xqt <i...@gno.de>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
