TheDJ has uploaded a new change for review.
https://gerrit.wikimedia.org/r/283858
Change subject: API: Allow subclassing ApiQueryImageInfo
......................................................................
API: Allow subclassing ApiQueryImageInfo
execute references the static self::getInfo, which therefor cannot be
overriden by the subclass ApiQueryVideoInfo. Preferably, we'd fix the
implementation to not require this subclassing, but so much is using
it, then i'd rather fix this subclass before going on a long road of
reimplementation.
The alternative to making this static is to use late static binding
btw. I have no preference.
Change-Id: Iab2d01abb9f9b3b799123d8ee344ea139e476576
---
M includes/api/ApiQueryImageInfo.php
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/58/283858/1
diff --git a/includes/api/ApiQueryImageInfo.php
b/includes/api/ApiQueryImageInfo.php
index ab94574..9461030 100644
--- a/includes/api/ApiQueryImageInfo.php
+++ b/includes/api/ApiQueryImageInfo.php
@@ -357,7 +357,7 @@
* 'revdelUser': User to use when checking whether to show
revision-deleted fields.
* @return array Result array
*/
- public static function getInfo( $file, $prop, $result, $thumbParams =
null, $opts = false ) {
+ public function getInfo( $file, $prop, $result, $thumbParams = null,
$opts = false ) {
global $wgContLang;
$anyHidden = false;
--
To view, visit https://gerrit.wikimedia.org/r/283858
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iab2d01abb9f9b3b799123d8ee344ea139e476576
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: TheDJ <hartman.w...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
