Addshore has uploaded a new change for review.
https://gerrit.wikimedia.org/r/283957
Change subject: RecentChange::parseParams will never return null
......................................................................
RecentChange::parseParams will never return null
Per the docs of unserialize:
In case the passed string is not unserializeable, false is returned.
Also as we can not guarentee an array was serialized in
rc_params we cant say it will always be an array...
Quite often this is just an empty string which will
result in: "s:0:"";" (not an array)....
Change-Id: Ib22f9f7468a23ce3d4f145d47f8514d08be6c957
---
M includes/changes/RecentChange.php
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/57/283957/1
diff --git a/includes/changes/RecentChange.php
b/includes/changes/RecentChange.php
index 2508304..7eda3ad 100644
--- a/includes/changes/RecentChange.php
+++ b/includes/changes/RecentChange.php
@@ -973,7 +973,7 @@
*
* @since 1.26
*
- * @return array|null
+ * @return mixed|false
*/
public function parseParams() {
$rcParams = $this->getAttribute( 'rc_params' );
--
To view, visit https://gerrit.wikimedia.org/r/283957
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib22f9f7468a23ce3d4f145d47f8514d08be6c957
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Addshore <addshorew...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
