Ejegg has submitted this change and it was merged.

Change subject: Support cancell?ed donations
......................................................................


Support cancell?ed donations

Bug: T129714
Change-Id: Iaf42acd9063264f1ec3a075ae09cb81c79ebaac1
---
M sites/all/modules/wmf_civicrm/wmf_civicrm.module
1 file changed, 9 insertions(+), 1 deletion(-)

Approvals:
  Ejegg: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/sites/all/modules/wmf_civicrm/wmf_civicrm.module 
b/sites/all/modules/wmf_civicrm/wmf_civicrm.module
index d67b68f..3f44ae4 100644
--- a/sites/all/modules/wmf_civicrm/wmf_civicrm.module
+++ b/sites/all/modules/wmf_civicrm/wmf_civicrm.module
@@ -1849,11 +1849,19 @@
     }
     $dbTransaction = new CRM_Core_Transaction();
 
+    // TODO: These are already getting normalized from processor codes in the
+    // classes that call this function so this is a bit redundant.
+    $validTypes = array(
+        'refund' => 'Refunded',
+        'chargeback' => 'Chargeback',
+        'cancel' => 'Cancelled'
+    );
+
     try {
       civicrm_api3('Contribution', 'create', array(
         'id' => $contribution_id,
         'debug' => 1,
-        'contribution_status_id' => ($refund_type == 'refund' ? 'Refunded' : 
'Chargeback'),
+        'contribution_status_id' => $validTypes[$refund_type],
         'cancel_date' => wmf_common_date_unix_to_civicrm($refund_date),
         'refund_trxn_id' => $refund_gateway_txn_id,
       ));

-- 
To view, visit https://gerrit.wikimedia.org/r/284011
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iaf42acd9063264f1ec3a075ae09cb81c79ebaac1
Gerrit-PatchSet: 2
Gerrit-Project: wikimedia/fundraising/crm
Gerrit-Branch: master
Gerrit-Owner: Cdentinger <cdentin...@wikimedia.org>
Gerrit-Reviewer: Awight <awi...@wikimedia.org>
Gerrit-Reviewer: Cdentinger <cdentin...@wikimedia.org>
Gerrit-Reviewer: Ejegg <eeggles...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to