jenkins-bot has submitted this change and it was merged. Change subject: Use transparent rather than white in icons ......................................................................
Use transparent rather than white in icons We had a few icons with white shapes painted over the black shapes, rather than "holes" in the black shapes. They would break in funny ways if we tried to color them. Found by grepping for 'fff'. Change-Id: I029715235f458928669a1840bc039f1bdcf58d77 --- M src/themes/apex/images/icons/flagUndo-ltr.svg M src/themes/apex/images/icons/flagUndo-rtl.svg M src/themes/mediawiki/images/icons/flagUndo-ltr.svg M src/themes/mediawiki/images/icons/flagUndo-rtl.svg M src/themes/mediawiki/images/icons/speechBubbleAdd-ltr.svg M src/themes/mediawiki/images/icons/speechBubbleAdd-rtl.svg 6 files changed, 6 insertions(+), 16 deletions(-) Approvals: Esanders: Looks good to me, approved jenkins-bot: Verified diff --git a/src/themes/apex/images/icons/flagUndo-ltr.svg b/src/themes/apex/images/icons/flagUndo-ltr.svg index fae0da1..516a3ea 100644 --- a/src/themes/apex/images/icons/flagUndo-ltr.svg +++ b/src/themes/apex/images/icons/flagUndo-ltr.svg @@ -1,6 +1,4 @@ <?xml version="1.0" encoding="utf-8"?> <svg xmlns="http://www.w3.org/2000/svg"; width="24" height="24" viewBox="0 0 24 24"> - <path d="M14 6.5V5c-1.4-1.5-5.2-1.2-6 0V4H7v15h1v-7c.8-.8 3.4-.9 5-.5V13c1.2 1.5 4.3 1.2 5 0V6c-.7.7-2.7.9-4 .5z"/> - <path d="M17.997 1.99l.99.99-15.98 15.98-.99-.99z"/> - <path d="M17 1.016l.99.99-15.98 15.98-.99-.99z" fill="#fff"/> + <path d="M18 2L2.03 17.97l.97 1 4-4V19h1v-5.03l2.688-2.69c.81-.02 1.645.053 2.312.22V13c1.2 1.5 4.3 1.2 5 0V6c-.493.493-1.635.725-2.72.688L19 2.968zM7 4v7.03l6.438-6.436C11.778 3.61 8.71 3.934 8 5V4z"/> </svg> diff --git a/src/themes/apex/images/icons/flagUndo-rtl.svg b/src/themes/apex/images/icons/flagUndo-rtl.svg index 0b14c25..8ed159e 100644 --- a/src/themes/apex/images/icons/flagUndo-rtl.svg +++ b/src/themes/apex/images/icons/flagUndo-rtl.svg @@ -1,6 +1,4 @@ <?xml version="1.0" encoding="utf-8"?> <svg xmlns="http://www.w3.org/2000/svg"; width="24" height="24" viewBox="0 0 24 24"> - <path d="M11 6.5V5c1.4-1.5 5.2-1.2 6 0V4h1v15h-1v-7c-.8-.8-3.4-.9-5-.5V13c-1.2 1.5-4.3 1.2-5 0V6c.7.7 2.7.9 4 .5z"/> - <path d="M7.003 1.99l-.99.99 15.98 15.98.99-.99z"/> - <path d="M8 1.016l-.99.99 15.98 15.98.99-.99z" fill="#fff"/> + <path d="M7 2l-1 .97 3.72 3.717C8.634 6.727 7.492 6.494 7 6v7c.7 1.2 3.8 1.5 5 0v-1.5c.667-.167 1.5-.24 2.313-.22L17 13.97V19h1v-4.03l4 4 .97-1zm7.22 2c-.952-.03-1.932.163-2.658.594L18 11.03V4h-1v1c-.4-.6-1.556-.963-2.78-1z"/> </svg> diff --git a/src/themes/mediawiki/images/icons/flagUndo-ltr.svg b/src/themes/mediawiki/images/icons/flagUndo-ltr.svg index fae0da1..516a3ea 100644 --- a/src/themes/mediawiki/images/icons/flagUndo-ltr.svg +++ b/src/themes/mediawiki/images/icons/flagUndo-ltr.svg @@ -1,6 +1,4 @@ <?xml version="1.0" encoding="utf-8"?> <svg xmlns="http://www.w3.org/2000/svg"; width="24" height="24" viewBox="0 0 24 24"> - <path d="M14 6.5V5c-1.4-1.5-5.2-1.2-6 0V4H7v15h1v-7c.8-.8 3.4-.9 5-.5V13c1.2 1.5 4.3 1.2 5 0V6c-.7.7-2.7.9-4 .5z"/> - <path d="M17.997 1.99l.99.99-15.98 15.98-.99-.99z"/> - <path d="M17 1.016l.99.99-15.98 15.98-.99-.99z" fill="#fff"/> + <path d="M18 2L2.03 17.97l.97 1 4-4V19h1v-5.03l2.688-2.69c.81-.02 1.645.053 2.312.22V13c1.2 1.5 4.3 1.2 5 0V6c-.493.493-1.635.725-2.72.688L19 2.968zM7 4v7.03l6.438-6.436C11.778 3.61 8.71 3.934 8 5V4z"/> </svg> diff --git a/src/themes/mediawiki/images/icons/flagUndo-rtl.svg b/src/themes/mediawiki/images/icons/flagUndo-rtl.svg index 0b14c25..8ed159e 100644 --- a/src/themes/mediawiki/images/icons/flagUndo-rtl.svg +++ b/src/themes/mediawiki/images/icons/flagUndo-rtl.svg @@ -1,6 +1,4 @@ <?xml version="1.0" encoding="utf-8"?> <svg xmlns="http://www.w3.org/2000/svg"; width="24" height="24" viewBox="0 0 24 24"> - <path d="M11 6.5V5c1.4-1.5 5.2-1.2 6 0V4h1v15h-1v-7c-.8-.8-3.4-.9-5-.5V13c-1.2 1.5-4.3 1.2-5 0V6c.7.7 2.7.9 4 .5z"/> - <path d="M7.003 1.99l-.99.99 15.98 15.98.99-.99z"/> - <path d="M8 1.016l-.99.99 15.98 15.98.99-.99z" fill="#fff"/> + <path d="M7 2l-1 .97 3.72 3.717C8.634 6.727 7.492 6.494 7 6v7c.7 1.2 3.8 1.5 5 0v-1.5c.667-.167 1.5-.24 2.313-.22L17 13.97V19h1v-4.03l4 4 .97-1zm7.22 2c-.952-.03-1.932.163-2.658.594L18 11.03V4h-1v1c-.4-.6-1.556-.963-2.78-1z"/> </svg> diff --git a/src/themes/mediawiki/images/icons/speechBubbleAdd-ltr.svg b/src/themes/mediawiki/images/icons/speechBubbleAdd-ltr.svg index 1b0db88..c7134c3 100644 --- a/src/themes/mediawiki/images/icons/speechBubbleAdd-ltr.svg +++ b/src/themes/mediawiki/images/icons/speechBubbleAdd-ltr.svg @@ -1,5 +1,4 @@ <?xml version="1.0" encoding="utf-8"?> <svg xmlns="http://www.w3.org/2000/svg"; width="24" height="24" viewBox="0 0 24 24"> - <path d="M19 20H2l3-3V6h17v11c0 1.7-1.3 3-3 3z"/> - <path fill="#fff" d="M13 9h1v7h-1zm-3 3h7v1h-7z"/> + <path d="M5 6v11l-3 3h17c1.7 0 3-1.3 3-3V6H5zm8 3h1v3h3v1h-3v3h-1v-3h-3v-1h3V9z"/> </svg> diff --git a/src/themes/mediawiki/images/icons/speechBubbleAdd-rtl.svg b/src/themes/mediawiki/images/icons/speechBubbleAdd-rtl.svg index ea9b849..08462e0 100644 --- a/src/themes/mediawiki/images/icons/speechBubbleAdd-rtl.svg +++ b/src/themes/mediawiki/images/icons/speechBubbleAdd-rtl.svg @@ -1,5 +1,4 @@ <?xml version="1.0" encoding="utf-8"?> <svg xmlns="http://www.w3.org/2000/svg"; width="24" height="24" viewBox="0 0 24 24"> - <path d="M5 20h17l-3-3V6H2v11c0 1.7 1.3 3 3 3z"/> - <path d="M11 9h-1v7h1zm3 3H7v1h7z" fill="#fff"/> + <path d="M2 6v11c0 1.7 1.3 3 3 3h17l-3-3V6H2zm8 3h1v3h3v1h-3v3h-1v-3H7v-1h3V9z"/> </svg> -- To view, visit https://gerrit.wikimedia.org/r/284108 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I029715235f458928669a1840bc039f1bdcf58d77 Gerrit-PatchSet: 1 Gerrit-Project: oojs/ui Gerrit-Branch: master Gerrit-Owner: Bartosz Dziewoński <matma....@gmail.com> Gerrit-Reviewer: Esanders <esand...@wikimedia.org> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
