TheDJ has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/284269

Change subject: Trigger transcode job for missing transcodes
......................................................................

Trigger transcode job for missing transcodes

We have many files for which a transcode of a particular type was
never initiated. This makes it so that when we try to list transcode
sources for a file and encounter such a situation, that we enqueue a
job that attempts to do this particular transcode.

This should be relatively safe (no transcode job explosion), since it
is only done on demand by usage of the file or file page.

Relates to T104061

Change-Id: I0c7583bd64f0e88e762924e8bdd157bc0acdc5b5
---
M WebVideoTranscode/WebVideoTranscode.php
1 file changed, 5 insertions(+), 0 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/TimedMediaHandler 
refs/changes/69/284269/1

diff --git a/WebVideoTranscode/WebVideoTranscode.php 
b/WebVideoTranscode/WebVideoTranscode.php
index 9c460f0..831d248 100644
--- a/WebVideoTranscode/WebVideoTranscode.php
+++ b/WebVideoTranscode/WebVideoTranscode.php
@@ -773,6 +773,11 @@
                if ( !isset( $transcodeState[ $transcodeKey ] ) ) {
                        return false;
                }
+               // If transcode was never added to jobqueue yet, do that now 
(T104061)
+               if ( is_null( $transcodeState[ $transcodeKey ]['time_addjob'] ) 
) {
+                       self::updateJobQueue( $file, $transcodeKey );
+                       return false;
+               }
                // Else return boolean ready state ( if not null, then ready ):
                return !is_null( $transcodeState[ $transcodeKey 
]['time_success'] );
        }

-- 
To view, visit https://gerrit.wikimedia.org/r/284269
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0c7583bd64f0e88e762924e8bdd157bc0acdc5b5
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/TimedMediaHandler
Gerrit-Branch: master
Gerrit-Owner: TheDJ <hartman.w...@gmail.com>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to