jenkins-bot has submitted this change and it was merged.
Change subject: WikiPageEntityMetaDataLookup force non quoted entityId in select
......................................................................
WikiPageEntityMetaDataLookup force non quoted entityId in select
Quoted large ints means mysql will use the incorrect index.
Bug: T131026
Change-Id: If2d435489d13707d27b583c658176c51048c5666
---
M lib/includes/Store/Sql/WikiPageEntityMetaDataLookup.php
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
Thiemo Mättig (WMDE): Looks good to me, approved
jenkins-bot: Verified
diff --git a/lib/includes/Store/Sql/WikiPageEntityMetaDataLookup.php
b/lib/includes/Store/Sql/WikiPageEntityMetaDataLookup.php
index 9d9ec26..e03b8b7 100644
--- a/lib/includes/Store/Sql/WikiPageEntityMetaDataLookup.php
+++ b/lib/includes/Store/Sql/WikiPageEntityMetaDataLookup.php
@@ -228,7 +228,9 @@
foreach ( $entityIds as &$entityId ) {
$where[] = $db->makeList( array(
// FIXME: this will fail for IDs that do not
have a numeric form
- 'epp_entity_id' => $entityId->getNumericId(),
+ // Note: if epp_entity_id is quoted the wrong
index will be used
+ // thus we cast it to int and leave it
unquoted
+ 'epp_entity_id = ' .
(int)$entityId->getNumericId(),
'epp_entity_type' => $entityId->getEntityType()
), LIST_AND );
}
--
To view, visit https://gerrit.wikimedia.org/r/282208
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If2d435489d13707d27b583c658176c51048c5666
Gerrit-PatchSet: 5
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Addshore <[email protected]>
Gerrit-Reviewer: Addshore <[email protected]>
Gerrit-Reviewer: Anomie <[email protected]>
Gerrit-Reviewer: Aude <[email protected]>
Gerrit-Reviewer: Daniel Kinzler <[email protected]>
Gerrit-Reviewer: Hoo man <[email protected]>
Gerrit-Reviewer: JanZerebecki <[email protected]>
Gerrit-Reviewer: Jcrespo <[email protected]>
Gerrit-Reviewer: Thiemo Mättig (WMDE) <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
